Skip to content

Add basic CI action#29

Open
mikekryjak wants to merge 13 commits into
mainfrom
add-ci
Open

Add basic CI action#29
mikekryjak wants to merge 13 commits into
mainfrom
add-ci

Conversation

@mikekryjak
Copy link
Copy Markdown
Collaborator

This adds a basic CI action based on xBOUT, but keeping it simple - just testing one Python version.
I still need to add a Ruff check.

  • Pytest action
  • Ruff action

Need the flexibility to plot an arbitrary selection, not just a named region. This also makes nomenclature consistent with sdtools.
It can plot either the RZ or poloidal grid
Now no longer relies on try/except for selections which are unavailable in a particular topology, which was bad design. Also correctly saves and retrieves the reference data.
Now RZ plot doesn't have the pink shading which can hide region boundaries. Also reduced font size in legend.
The guards can be either guard replaced or removed by the user. This is much easier than adding guards to the selection later.
Update for fix in yguards, add image generation
Copy link
Copy Markdown
Contributor

@dschwoerer dschwoerer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not checked the region selectors, as I do not use them, but having a CI is great.

I would be happy for this to get merged. Having a ruff CI could follow in a later PR.

@mikekryjak mikekryjak mentioned this pull request Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants