Skip to content

Remove t_array to prevent duplicate times in dataset #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dschwoerer merged 2 commits into from
Apr 28, 2026
Merged

Remove t_array to prevent duplicate times in dataset #346

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7515cbc
Remove unnecessary t coord creation in lazy_load
mikekryjak Apr 27, 2026
051d189
Always drop t_array if present
mikekryjak Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions xbout/geometries.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,12 +127,15 @@ def apply_geometry(ds, geometry_name, *, coordinates=None, grid=None):
ycoord = updated_ds.metadata["bout_ydim"]
zcoord = updated_ds.metadata["bout_zdim"]

if (tcoord not in updated_ds.coords) and (tcoord in updated_ds.dims):
if "t_array" in updated_ds:
# Always use t_array as the ground truth for the time coordinate

# Create the time coordinate from t_array
# Slightly odd looking way to create coordinate ensures 'index variable' is
# created, which using set_coords() does not (possible xarray bug?
# https://github.com/pydata/xarray/issues/4417
updated_ds[tcoord] = updated_ds["t_array"]
if tcoord in updated_ds.dims:
updated_ds[tcoord] = updated_ds["t_array"]
updated_ds = updated_ds.drop_vars("t_array")

if xcoord not in updated_ds.coords:
Expand Down
6 changes: 1 addition & 5 deletions xbout/lazyload.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,9 +360,5 @@ def lazy_open_boutdataset(
f"Variable '{name}' has only one of x/y dimensions and will be skipped"
)

coords = {}
if "t_array" in ds:
coords["t"] = ds["t_array"].values

# Create a global dataset
return xr.Dataset(data_vars, coords=coords, attrs={"metadata": metadata})
return xr.Dataset(data_vars, attrs={"metadata": metadata})
Loading