Skip to content

Fixes for components, species list#566

Merged
bendudson merged 1 commit into
masterfrom
codex-fixes
May 15, 2026
Merged

Fixes for components, species list#566
bendudson merged 1 commit into
masterfrom
codex-fixes

Conversation

@bendudson
Copy link
Copy Markdown
Collaborator

@bendudson bendudson commented May 15, 2026

Three fixes found by Codex:
component.hxx SpeciesInformation called finish_construction multiple times

-      finish_construction();
     }
+    finish_construction();

component.cxx declareAllSpecies substituted "charged" twice rather than substituting "charged2"

-    state_variable_access.substitute("charged", info.charged);
+    state_variable_access.substitute("charged2", info.charged);

component_scheduler.cxx ComponentScheduler used "name" rather than "name_trimmed" in comparison

-    if (name_trimmed == "e" or name == "ebeam") {
+    if (name_trimmed == "e" or name_trimmed == "ebeam") {

Mostly formatting due to touching component.cxx

Three fixes found by Codex:
component.hxx SpeciesInformation called finish_construction multiple times
-      finish_construction();
     }
+    finish_construction();

component.cxx declareAllSpecies substituted "charged" twice rather
than substituting "charged2"
-    state_variable_access.substitute("charged", info.charged);
+    state_variable_access.substitute("charged2", info.charged);

component_scheduler.cxx ComponentScheduler used "name" rather than
"name_trimmed" in comparison
-    if (name_trimmed == "e" or name == "ebeam") {
+    if (name_trimmed == "e" or name_trimmed == "ebeam") {

Mostly formatting due to touching component.cxx
@codecov
Copy link
Copy Markdown

codecov Bot commented May 15, 2026

Codecov Report

❌ Patch coverage is 78.04878% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.54%. Comparing base (8220ead) to head (1391033).

Files with missing lines Patch % Lines
src/component_scheduler.cxx 52.94% 6 Missing and 2 partials ⚠️
src/component.cxx 95.65% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #566   +/-   ##
=======================================
  Coverage   48.54%   48.54%           
=======================================
  Files          96       96           
  Lines        9842     9842           
  Branches     1435     1434    -1     
=======================================
  Hits         4778     4778           
  Misses       4574     4574           
  Partials      490      490           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bendudson bendudson merged commit 3a259b0 into master May 15, 2026
6 checks passed
@bendudson bendudson deleted the codex-fixes branch May 15, 2026 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant