Fixes for components, species list#566
Merged
Merged
Conversation
Three fixes found by Codex:
component.hxx SpeciesInformation called finish_construction multiple times
- finish_construction();
}
+ finish_construction();
component.cxx declareAllSpecies substituted "charged" twice rather
than substituting "charged2"
- state_variable_access.substitute("charged", info.charged);
+ state_variable_access.substitute("charged2", info.charged);
component_scheduler.cxx ComponentScheduler used "name" rather than
"name_trimmed" in comparison
- if (name_trimmed == "e" or name == "ebeam") {
+ if (name_trimmed == "e" or name_trimmed == "ebeam") {
Mostly formatting due to touching component.cxx
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #566 +/- ##
=======================================
Coverage 48.54% 48.54%
=======================================
Files 96 96
Lines 9842 9842
Branches 1435 1434 -1
=======================================
Hits 4778 4778
Misses 4574 4574
Partials 490 490 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three fixes found by Codex:
component.hxx SpeciesInformation called finish_construction multiple times
component.cxx declareAllSpecies substituted "charged" twice rather than substituting "charged2"
component_scheduler.cxx ComponentScheduler used "name" rather than "name_trimmed" in comparison
Mostly formatting due to touching component.cxx