Improved neutral flux limiters - clean#556
Open
mikekryjak wants to merge 1 commit into
Open
Conversation
- Separate free streaming definitions for advection, conduction, viscosity - Separate limiters for perpendicular and parallel transport - Corrected thermal speed formulation - No longer double counting neutral_lmax - Legacy behaviour can be enabled with flags
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR isolates just the flux limiter changes from #451:
To do:
I have found a considerable performance hit even when using SNES with the MUMPS recipe. I suspect it's purely due to the faster neutral transport but not sure yet.
It makes me wonder whether we should have the new or the legacy model as the default. I am really struggling to decide!
At the moment the legacy behaviour can be enabled by three separate flags, one for the limiter form, one for double-counting
neutral_lmaxand one for the old thermal speed formula.What are your thoughts @bendudson @dschwoerer @malamast? Should the default be more physically accurate or fast?