Update BOUT++ to latest version and fix sheath_ion_heat_flux

[dschwoerer]

No description provided.

[dschwoerer]

a826725 might be impacting some simulations, depending on the normalisation.

[codecov]

Codecov Report

❌ Patch coverage is 49.61832% with 66 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.40%. Comparing base (ce0ea3b) to head (200a1d2).

Files with missing lines	Patch %	Lines
src/vorticity.cxx	58.00%	19 Missing and 2 partials ⚠️
src/evolve_density.cxx	48.48%	16 Missing and 1 partial ⚠️
src/evolve_momentum.cxx	52.94%	16 Missing ⚠️
src/evolve_energy.cxx	0.00%	12 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #549      +/-   ##
==========================================
+ Coverage   47.29%   47.40%   +0.10%     
==========================================
  Files          96       96              
  Lines        9828     9873      +45     
  Branches     1428     1428              
==========================================
+ Hits         4648     4680      +32     
- Misses       4704     4716      +12     
- Partials      476      477       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[mikekryjak]

What was the issue with sheath_ion_heat_flux and what is the fix?

[dschwoerer]

from a826725:

Do not convert to int

abs is for integers (from C)
std::abs is for anything (from C++)

Previously, the flux was converted to an integer, and thus was reduced. How much, depends on the normalisation.

[mikekryjak]

No way.. I didn't know about that. Have you checked if there are other instances of this elsewhere in the code?

[dschwoerer]

I did not see any other compiler warning, so I think it is fine ...