Fci: Add 3D MMS tests and fix neutral averaging#537
Open
totork wants to merge 25 commits into
Open
Conversation
Add tests of sheath physics to FCI
dschwoerer
reviewed
Apr 20, 2026
Collaborator
dschwoerer
left a comment
dschwoerer
left a comment
There was a problem hiding this comment.
It would be nice to remove the python2 fallback paths as well.
Otherwise, this seems pretty straight forward 👍
Fix amjuel reaction averaging that cause slow down
Delete more averaging
Co-authored-by: David Bold <dave@ipp.mpg.de>
totork
changed the title
dschwoerer
reviewed
May 6, 2026
| - name: Install pip packages | ||
| run: | | ||
| ./.pip_install_for_tests.sh 'netcdf4~=1.5' 'boutdata==0.3.0' boututils 'git+https://github.com/boutproject/zoidberg@better-metric' | ||
| ./.pip_install_for_tests.sh 'netcdf4~=1.5' 'boutdata==0.3.0' boututils 'git+https://github.com/boutproject/zoidberg' |
Collaborator
There was a problem hiding this comment.
Suggested change
| ./.pip_install_for_tests.sh 'netcdf4~=1.5' 'boutdata==0.3.0' boututils 'git+https://github.com/boutproject/zoidberg' | |
| ./.pip_install_for_tests.sh 'netcdf4~=1.5' 'boutdata==0.3.0' boututils zoidberg |
or
Suggested change
| ./.pip_install_for_tests.sh 'netcdf4~=1.5' 'boutdata==0.3.0' boututils 'git+https://github.com/boutproject/zoidberg' | |
| ./.pip_install_for_tests.sh 'netcdf4~=1.5' 'boutdata!=0.4.0' boututils zoidberg |
so we get the next boutdata automatically.
Author
There was a problem hiding this comment.
Last time I used boutdata=0.4.0, I would get weird errors and the CI would fail all over the place. I am not sure if this is the case anymore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does add more MMS test, now in a more realistic 3D geometry. The magnetic field is axial and circular with a finite q-profile. The q profile can be varied radially, but is kept constant for these tests (q=3). There are 2 tests:
As the field is axial, the field strength on a field line stays constant, which means that it does not test flux expansion.
These tests also install Zoidberg/better-metric in the CI. Building this PR requires a Zoidberg version, atleast for all the tests. I am not sure if the hermes-3 executable is built properly when zoidberg is not found.