Unit tests and style changes for neutral_mixed.cxx#480
Merged
mrhardman merged 3 commits intoJan 29, 2026
Merged
Conversation
…ure.cxx or evolve_density.cxx. Introduce a similar set of unit tests. The integration tests fail: the changes have unexpectedly broken the component.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## nonorthogonal-divops-mms-test-minimal #480 +/- ##
=========================================================================
+ Coverage 28.89% 34.12% +5.22%
=========================================================================
Files 94 94
Lines 8959 8956 -3
Branches 1249 1246 -3
=========================================================================
+ Hits 2589 3056 +467
+ Misses 6105 5605 -500
- Partials 265 295 +30 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
@mikekryjak @bendudson Tests are now passing since 0eab680. Could you please provide a review indicating whether or not these style changes break an untested feature? Further tests can be added if necessary. |
mikekryjak
approved these changes
Jan 28, 2026
mrhardman
merged commit e41bc2c
into
nonorthogonal-divops-mms-test-minimal
5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to bring style of neutral_mixed.cxx in line with evolve_pressure.cxx or evolve_density.cxx. Introduce a similar set of unit tests. The integration tests fail: the changes have unexpectedly broken the component.
To address #476 I have tried to change the style of
neutral_mixed.cxxto enable testing in the same manner as e.g.,evolve_densityandevolve_pressure.EDIT: Integrated and unit tests now passing.