-
Notifications
You must be signed in to change notification settings - Fork 28
Nonorthogonal with minimal differential operators MMS test. #285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 51 commits
Commits
Show all changes
150 commits
Select commit
Hold shift + click to select a range
18ac63e
Div_a_Grad_perp_nonorthog function for testing
bendudson 809ed4b
Clang formatting
bendudson 8156075
neutral_mixed: Use Div_a_Grad_perp_nonorthog
bendudson 910a0c4
Merge branch 'master' into nonorthogonal
bendudson aadc272
Attempt to port David Bold`s MMS test to Hermes-3.
mrhardman 8f847a9
Read Rxy and Zxy from mesh file (hypnotoad), do not write 3D R Z to f…
mrhardman b0f380f
Merge branch 'master' into divops-mms-test
mrhardman f43cc54
Initial commit of files needed to port David Bold's MMS differential …
mrhardman fe91bd7
Changes to makes mms.py script run.
mrhardman cdb7be3
Reorganise and comment the mms.py test script.
mrhardman fdc7d1e
Reorganise and comment the mms.py test script, remove unused code.
mrhardman 0b6b066
Reorganise the mms.py test script, rationalise plotting.
mrhardman 427e76e
Add script to generate circular closed-field-line equilibria for the …
mrhardman a05eeed
Make test BOUT.inp file use a third circular equilibrium.
mrhardman 4685453
Restore variable path input functionality, rename main function to mo…
mrhardman 73e5c49
Rename variables to clarify meaning.
mrhardman fd9192d
Modify plot to show expected convergence order, calculate convergence…
mrhardman 12488c3
Refactor plotting so that each test is a unique plot, experiment with…
mrhardman 86aaa19
Comment out Poisson bracket tests for now from main.cxx.
mrhardman e020cd4
Make modifications to test the feasibility of MMS test in a slab with…
mrhardman 7fa43c7
Reduce main.cxx for MMS test to the minimal code for a single operator
johnomotani 11ba89e
Initial python script for running minimal MMS test, no plotting of re…
mrhardman 7f55ffe
Start adding i/o result testing functionality.
mrhardman 90677d8
Bare minimum script to compare analytical and numerical results, usin…
mrhardman 071850d
Change syntax of open_boutdataset() to use xBOUT branch fix-gridless-…
mrhardman ef7aeeb
Make sure g** are taken from a single source, accomodate trivial agre…
mrhardman e674d04
Cut down seemingly unused options in BOUT.input.template.
mrhardman 4b5c896
Support the ability to deal with polynomial test functions.
mrhardman b828e7f
Changes needed to get minimal MMS test to work, showing expected rate…
mrhardman a4a2da4
Include C language to permit compiling of C dependencies.
mrhardman e4b849e
Merge branch 'divops-mms-test-minimal' into nonorthogonal-divops-mms-…
mrhardman b010265
Add Div_a_Grad_perp_nonorthog to run-jobs.py and main.cxx to permit e…
mrhardman 4f2025e
Correct label on plots
mrhardman 3d11cb7
Bugfix: correct position of parenthesis in ddz affecting g13 term in …
mrhardman a151fd7
Test g11 to make sure it is calculated properly.
mrhardman 2e5e827
Bugfix: correct indexing error in Y flux affecting g12 nonorthogonal …
mrhardman fc3d32b
Make coefficients differ from one another in analytical prescription.…
mrhardman 0f488c9
Make sure a = a(x,y,z) is tested. MMS test currently passes.
mrhardman 890a9b3
Start development of version of test for automated tests.
mrhardman 0bac5f5
Add ability for tests/mms/main.cxx to loop over a list of operators, …
mrhardman 4bbe4ec
Generalise main.cxx and run-jobs-2.py so that list of operators and s…
mrhardman 1aef2ee
Send rate -> order in output message.
mrhardman 8fcd604
Refactored MMS test to allow for different metrics to be tested on op…
mrhardman 8aae139
Remove older revisions of test for clarity in ongoing development.
mrhardman 101697e
Make sure to make root test directory.
mrhardman 31e9af0
Correct minor typos.
mrhardman 17238a6
Include differential operator tests in CMakelists.txt correctly
mrhardman 4698c47
Make interactive plotting optional.
mrhardman da10095
Try to change .pip_install_for_tests.sh to make sure we have the late…
mrhardman 62b9f4a
Some documentation for the tests.
mrhardman 607780a
Make sure plots saved in appropriate directory.
mrhardman cd679c8
Remove unnecessary code for MMS tests in CMakelists.txt.
mrhardman ca23fb9
Update src/div_ops.cxx
mrhardman dd95973
Update src/div_ops.cxx
mrhardman ab2831e
Merge branch 'nonorthogonal-divops-mms-test-minimal' of https://githu…
mrhardman 6b11132
Revert "Update src/div_ops.cxx
"
mrhardman 7bd1012
Use David Bold suggestion to streamline `.pip_install_for_tests.sh`.
mrhardman 70a15e1
Update docs to make it clear that xBOUT needs to be installed from gi…
mrhardman 05ef0a9
Note on debug flags for Spack notes.
mrhardman 8ac40c7
Update src/classical_diffusion.cxx to use Div_a_Grad_perp_nonorthog().
mrhardman 9ecddeb
Modify src/classical_diffusion.cxx to permit use diffusing neutral de…
mrhardman a85ca79
Initial attempt to merge, noting limitation of lack of flows diagnost…
mrhardman 7bf3405
Changes to incorporate flow diagnostics into tests.
mrhardman b337a1c
Address issue #306.
690c1ff
Attempt to comment out terms not involving Div_a_Grad_perp_nonorthog().
mrhardman 07a7b12
Manually set diagnostic fluxes to zero values to prevent error -- Err…
mrhardman bf6ec90
Link to latest next for BOUT-dev
mrhardman d7de1d3
Attempt to simply problem by making diffusion coeffs constant. Strang…
mrhardman 49de072
Revert "Attempt to simply problem by making diffusion coeffs constant…
mrhardman 17ffec0
Revert "Manually set diagnostic fluxes to zero values to prevent erro…
mrhardman be76c99
Revert "Attempt to comment out terms not involving Div_a_Grad_perp_no…
mrhardman d36e797
Add Div_par_K_Grad_par to differential operator test.
mrhardman 79b76b6
Add Div_par to differential operator test.
mrhardman 3b85531
Add Grad_par to differential operator test.
mrhardman 5e5edf8
Add Div_par_fvv() to differential operator test. Convergence order ap…
mrhardman fb4c940
Make test take an extra variable in "differential_operator_list", the…
mrhardman 14b14f1
Add FV::Div_par_mod() to differential operator test. Worth noting tha…
mrhardman 06a8605
Initial work to make an MMS test of neutral_mixed based on calculatin…
mrhardman c0d3968
Add symbolic Nn, Pn, and sources to test script and BOUT.inp file. Co…
mrhardman 6e48518
Extend neutral_mixed test functionality to makes plots of error.
mrhardman 16e9a0d
Increase resolution to larger values.
mrhardman c0afe38
Add an override option for neutral collision frequency to make testin…
mrhardman 03d7add
Make neutral_mixed MMS test 2D.
mrhardman 9ba9502
Reduce tolerance rtol to ensure implicit timestepping iterative error…
mrhardman 94943ac
Sanity check, test absolute difference in Nd and Pd as well as ddt() …
mrhardman 9aef275
Add choice of density floor, logical for neutral conduction, 5/3 fact…
mrhardman 610918e
Test only 1 RHS evaluation, no timestepping.
mrhardman 05d4159
Make reference values unity.
mrhardman 1711c4e
Print out RMS values of Nd Pd for sanity checks.
mrhardman ed805a9
Make sure metric is not normalised.
mrhardman 7279498
Supply J and g_* coeffs explicitly.
mrhardman 911ca20
Remove normalisations from sources.
mrhardman daa56c3
Fix typo using Nn rather than Pn for pressure evolution in diffusion …
mrhardman 29e3241
Revert "Remove normalisations from sources."
mrhardman fe7446f
Give option to not normalise the input sources to neutral_mixed.cxx, …
mrhardman d7ec8ac
Make sure Pn and Nn satisfy neumann boundary condition in x.
mrhardman e5741be
Add facility for checking relative conservation, normalise the errors…
mrhardman 91e4e56
Include NVd in MMS test of neutral mixed for conservation_test=False.
mrhardman 5adc3ee
Test conservation of energy when NVd is evolved.
mrhardman a9232d2
Wrapper function to make clear how to switch between different test t…
mrhardman b1664a9
Changes to permit tests to run in sequence from a single python scrip…
mrhardman 758ae1d
Add automatic test of the RHS of the time evolution equations for neu…
mrhardman 9b21f53
Complete momentum source feature consistent with other options, so th…
mrhardman ac4f3c4
Attempt to avoid CI-test failure by using `launch()` function to run …
mrhardman f841004
Specify number of threads, include same functions as in other (integr…
mrhardman f041903
Corrected typo
cmacmackin 9355515
Revert "Corrected typo"
cmacmackin 661e8ad
Debugging CI failure
cmacmackin 2843b15
Display output for CI debugging
cmacmackin b723bf3
Better error handling in MMS tests
cmacmackin 3527d94
Switched solver to one available in CI
cmacmackin ff2180a
Print statements for debugging CI
cmacmackin 9859f3c
Further debugging; plus speed up build in CI
cmacmackin 75f460e
Try loading all BOUT data immediately
cmacmackin be8a557
Revert CI debugging work
cmacmackin dff393e
Load BOUT++ datasets eagerly
cmacmackin 04dea52
Use parallel builds in CI
cmacmackin 1e44233
Close datasets in response to @d7919.
mrhardman 11f6930
Update tests/mms/main.cxx: @ZedThree suggestion.
mrhardman 1e0d13b
@ZedThree comment, use fmt::format to reduce lines of code.
mrhardman a869e7c
Merge branch 'master' into nonorthogonal-divops-mms-test-minimal
mrhardman 786ed71
Merge master into nonorthogonal-divops-mms-test-minimal.
mrhardman 7c0458e
Attempt to restore div_ops MMS test to CI.
mrhardman 0f9d6f4
Merge nonorthogonal-divops-mms-test-minimal to keep track of changes …
mrhardman 9c54998
CRLF to LF line endings.
mrhardman 0b6d06c
Attempt to install h5py manually to avoid HDF5 error on integration t…
mrhardman 32c8536
Refactor mms tests to enhance similarity to mms functions from `boutd…
mrhardman e600761
Attempt to print package versions in a test failing on Actions.
mrhardman 099f6ed
Attempt to pin xBOUT for CI tests to the version that is used by the …
mrhardman 5127ae5
Attempt to pin xBOUT for CI tests to the version that is used by the …
mrhardman 6704dd1
Merge branch 'nonorthogonal-debug' of github.com:boutproject/hermes-3…
mrhardman 27e243f
Ensure dataset is closed in `tests/integrated/drift-wave/analysis.py`
mrhardman fffa411
Revert "Attempt to print package versions in a test failing on Actions."
mrhardman ab489e3
Revert "Attempt to install h5py manually to avoid HDF5 error on integ…
mrhardman 17a9578
Remove unused code in `/tests/mms/perpendicular_laplacian.py`.
mrhardman 28a2e4d
@ZedThree suggestions regarding job execution.
mrhardman ce7b5fb
Revert "@ZedThree suggestions regarding job execution."
mrhardman 060c6b3
Use launch_safe() to run jobs.
mrhardman f6e4723
Merge pull request #327 from boutproject/nonorthogonal-debug
mrhardman e97c363
Remame `hermes_mms_tests` to `hermes_mms_operator_tests`, and `tests/…
mrhardman 73c8879
Rename `rnn_override` to `collisionality_override`. Remove trailing w…
mrhardman 696bac8
Result of `$ git-clang-format 053c9bb70b66ffd3ac603477f76c5866a0b9e33c`.
mrhardman 633550d
Basic unit test of `neutral_mixed`, based on tests for `evolve_densit…
mrhardman 087e602
Attempt to bring style of neutral_mixed.cxx in line with evolve_press…
mrhardman 0eab680
Fix typo -> get velocity in local state for the `Vn` variable, not de…
mrhardman 8d14014
Add some terse comments explaining the nature of the unit tests.
mrhardman e41bc2c
Merge pull request #480 from boutproject/neutral-mixed-style-and-unit…
mrhardman d5086d4
Merge branch 'master' into nonorthogonal-divops-mms-test-minimal
mrhardman 2b3a1fc
Result of `git-clang-format 6704dd1e5bace43a27dc3f29781157a237aa428f`…
mrhardman 49a5cce
Apply clang-format changes
mrhardman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.