BM-679: Commit to requestId and requestDigest in Assessor #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
capossele
requested review from
Wollac,
zeroecco,
austinabell,
willemolding,
rlukata and
a team
as code owners
github-actions
bot
changed the title
This reverts commit 99c41bd.
willpote
approved these changes
Mar 25, 2025
nategraf
reviewed
Mar 25, 2025
crates/assessor/src/lib.rs
Outdated
| /// - The request ID. | ||
| /// - The request digest. | ||
| /// - The claim digest. | ||
| pub fn commit( |
There was a problem hiding this comment.
We should use a struct here and domain separation (e.g. EIP-712) instead of just concatting these bytes.
There was a problem hiding this comment.
done with 3a2da80.
However, the gas cost of using that is not negligible
There was a problem hiding this comment.
Gas released issue fixed in cdaceae
contracts/test/TestUtils.sol
Outdated
| requestDigests[i] = fills[i].requestDigest; | ||
| } | ||
| bytes32 root = MerkleProofish.processTree(claimDigests); | ||
| bytes32 root = MerkleProofish.processTree(leaves); | ||
|
|
||
| bytes memory journal = abi.encode( | ||
| AssessorJournal({ |
There was a problem hiding this comment.
We should also drop the requestDigests field from AssessorJournal since is is now redundant.
There was a problem hiding this comment.
done with 3a2da80
nategraf
approved these changes
Mar 26, 2025
capossele
deleted the
angelo/bm-679-prevent-re-ordering-of-fulfillments-in-batches
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses both #436 and #437 issues by committing to the positional index, the
requestIdandrequestDigestas part of the leaf body in the assessor tree.Closes BM-678
Closes BM-679