BM-658: Add proper error handling for eth value string parsing failure #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
willemolding
commented
Mar 17, 2025
willemolding
commented
- Addresses silent failure on parsing highlighted in BM-534: Add configurable warning and error logs for broker balance #321 (comment)
willemolding
requested review from
capossele,
Wollac,
zeroecco,
austinabell,
rlukata and
a team
as code owners
github-actions
bot
changed the title
nategraf
approved these changes
Mar 17, 2025
austinabell
approved these changes
Mar 18, 2025
Signed-off-by: Willem Olding <[email protected]>
Signed-off-by: Willem Olding <[email protected]>
willemolding
force-pushed
the
willem/fail-on-alert-threshold-parsing
branch
from
4823671 to
59264d2
Compare
willpote
pushed a commit
that referenced
this pull request
Mar 19, 2025
#411) - Addresses silent failure on parsing highlighted in #321 (comment)
willpote
pushed a commit
that referenced
this pull request
Mar 19, 2025
#411) - Addresses silent failure on parsing highlighted in #321 (comment)
willpote
pushed a commit
that referenced
this pull request
Mar 19, 2025
#411) - Addresses silent failure on parsing highlighted in #321 (comment)
nategraf
pushed a commit
that referenced
this pull request
Mar 20, 2025
#411) - Addresses silent failure on parsing highlighted in #321 (comment)
nategraf
pushed a commit
that referenced
this pull request
Mar 21, 2025
#411) - Addresses silent failure on parsing highlighted in #321 (comment)
nategraf
pushed a commit
that referenced
this pull request
Mar 21, 2025
#411) - Addresses silent failure on parsing highlighted in #321 (comment)
nategraf
pushed a commit
that referenced
this pull request
Mar 21, 2025
#411) - Addresses silent failure on parsing highlighted in #321 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.