Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BM-476: Callbacks #335

Merged
merged 60 commits into from
Mar 5, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
60 commits
Select commit Hold shift + click to select a range
dd6417c
add Selector
capossele Feb 7, 2025
000212b
add tests
capossele Feb 7, 2025
04c5f30
Merge branch 'main' into angelo/bm-459-explore-options-for-delivering…
capossele Feb 7, 2025
29a51a6
Merge branch 'main' into angelo/bm-459-explore-options-for-delivering…
capossele Feb 12, 2025
169e1e8
fix build
capossele Feb 13, 2025
f435b3e
fix tests
capossele Feb 13, 2025
4af979e
comment out optimizer_runs
capossele Feb 13, 2025
12f691a
fix invalidSignature
capossele Feb 14, 2025
4d6da56
Merge branch 'main' into angelo/bm-459-explore-options-for-delivering…
capossele Feb 14, 2025
3b687ca
format
capossele Feb 14, 2025
1dd5d01
set optimizer_runs to 1k
capossele Feb 14, 2025
515740e
fix tests after merge
capossele Feb 14, 2025
31eff96
update artifacts
capossele Feb 14, 2025
b1bb28d
Merge branch 'main' into angelo/bm-459-explore-options-for-delivering…
capossele Feb 14, 2025
5a27fbb
add FulfillmentAssessor struct
capossele Feb 18, 2025
c71d22b
use assessor_fill in rust code
capossele Feb 18, 2025
a219d17
Merge branch 'main' into angelo/bm-459-explore-options-for-delivering…
capossele Feb 18, 2025
92b2c60
drop new line
capossele Feb 18, 2025
bf8c59e
Merge branch 'main' into angelo/bm-459-explore-options-for-delivering…
capossele Feb 19, 2025
b9903b4
fix test
capossele Feb 19, 2025
4635cff
update artifacts
capossele Feb 19, 2025
7eaa3c6
drop extra loop
capossele Feb 19, 2025
6b6ae44
drop Selector type
capossele Feb 19, 2025
7af67da
add benchmark
capossele Feb 19, 2025
fc802c4
fmt
capossele Feb 19, 2025
44ccd00
drop SelectorsLib
capossele Feb 19, 2025
671c862
feedback
capossele Feb 20, 2025
bec7047
Merge branch 'main' into angelo/bm-459-explore-options-for-delivering…
capossele Feb 20, 2025
06e0186
introduce BatchSizeExceedsLimit error
capossele Feb 20, 2025
57d5985
Add callback support
willpote Feb 18, 2025
c0765b3
Lint
willpote Feb 21, 2025
8bd607d
Merge branch 'main' into angelo/bm-459-explore-options-for-delivering…
capossele Feb 23, 2025
bb6aae6
License and lint fixes
willpote Feb 24, 2025
d03de63
Merge branch 'main' into angelo/bm-459-explore-options-for-delivering…
capossele Feb 25, 2025
ec2f451
refactor contract side
capossele Feb 25, 2025
e666cac
refactor rust side
capossele Feb 25, 2025
4c0884b
cleanup
capossele Feb 25, 2025
2e28f8e
fix test with selectors
capossele Feb 25, 2025
f9b4cd5
Fix
willpote Feb 27, 2025
7017a53
Apply suggestions from code review
capossele Feb 28, 2025
93e8d5d
Merge branch 'main' into angelo/bm-459-explore-options-for-delivering…
capossele Feb 28, 2025
9de0a66
feedback
capossele Feb 28, 2025
49f7f40
fmt
capossele Feb 28, 2025
080ad89
Pre-merge
willpote Feb 28, 2025
38b1fa1
Merge remote-tracking branch 'origin/angelo/bm-459-explore-options-fo…
willpote Mar 2, 2025
749a449
Old fulfill flow
willpote Mar 2, 2025
0267e30
Revert "Old fulfill flow"
willpote Mar 2, 2025
09890af
Minor gas golf
willpote Mar 2, 2025
85c4d67
Gas
willpote Mar 2, 2025
208ab3b
Fmt
willpote Mar 2, 2025
5fa8d05
Comment
willpote Mar 3, 2025
c048deb
Merge branch 'main' of github.com:boundless-xyz/boundless into willpo…
nategraf Mar 5, 2025
487a9e9
remove unused callback fields from FulfillmentContext
nategraf Mar 5, 2025
e56e3f5
update snapshots
nategraf Mar 5, 2025
f59f35c
revert changes to comments to match unchanged code
nategraf Mar 5, 2025
612ebef
update artifacts
nategraf Mar 5, 2025
2f27f94
Review of #335: simplify fulfillAndPay by extracting callback (#364)
nategraf Mar 5, 2025
8daba10
Merge branch 'main' into willpote/callbacks-2
willpote Mar 5, 2025
5449327
Update crates/boundless-cli/src/bin/boundless-cli.rs
willpote Mar 5, 2025
206a960
Artifacts
willpote Mar 5, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 28 additions & 28 deletions contracts/snapshots/BoundlessMarketBasicTest.json
Original file line number Diff line number Diff line change
@@ -1,32 +1,32 @@
{
"ERC20 approve: required for depositStake": "45966",
"bytecode size implementation": "21692",
"bytecode size implementation": "22914",
"bytecode size proxy": "89",
"deposit: first ever deposit": "50845",
"deposit: second deposit": "33745",
"depositStake: 1 HP (tops up market account)": "60172",
"depositStake: full (drains testProver account)": "50572",
"depositStakeWithPermit: 1 HP (tops up market account)": "72946",
"depositStakeWithPermit: full (drains testProver account)": "72936",
"fulfill: a locked request": "77815",
"fulfill: a locked request (locked via prover signature)": "77815",
"fulfill: another prover fulfills without payment": "72643",
"fulfill: fulfilled by the locked prover for payment (request already fulfilled by another prover)": "73163",
"fulfillBatch: a batch of 8": "323752",
"lockinRequest: base case": "114958",
"lockinRequest: with prover signature": "121076",
"priceAndFulfillBatch: a single request": "104157",
"priceAndFulfillBatch: a single request (with selector)": "106317",
"priceAndFulfillBatch: a single request that was not locked": "104169",
"priceAndFulfillBatch: a single request that was not locked fulfilled by prover not in allow-list": "104169",
"slash: base case": "87206",
"slash: fulfilled request after lock deadline": "61847",
"submitRequest: with maxPrice ether": "51587",
"submitRequest: without ether": "44702",
"submitRootAndFulfillBatch: a batch of 2 requests": "148200",
"unfreezeAccount": "31556",
"withdraw: 1 ether": "40517",
"withdraw: full balance": "40529",
"withdrawStake: 1 HP balance": "68985",
"withdrawStake: full balance": "51981"
"deposit: first ever deposit": "50823",
"deposit: second deposit": "33723",
"depositStake: 1 HP (tops up market account)": "60150",
"depositStake: full (drains testProver account)": "50550",
"depositStakeWithPermit: 1 HP (tops up market account)": "72964",
"depositStakeWithPermit: full (drains testProver account)": "72954",
"fulfill: a locked request": "79478",
"fulfill: a locked request (locked via prover signature)": "79478",
"fulfill: another prover fulfills without payment": "74377",
"fulfill: fulfilled by the locked prover for payment (request already fulfilled by another prover)": "74806",
"fulfillBatch: a batch of 8": "322906",
"lockinRequest: base case": "117183",
"lockinRequest: with prover signature": "122873",
"priceAndFulfillBatch: a single request": "107094",
"priceAndFulfillBatch: a single request (with selector)": "109218",
"priceAndFulfillBatch: a single request that was not locked": "107082",
"priceAndFulfillBatch: a single request that was not locked fulfilled by prover not in allow-list": "107082",
"slash: base case": "87250",
"slash: fulfilled request after lock deadline": "61891",
"submitRequest: with maxPrice ether": "51990",
"submitRequest: without ether": "45105",
"submitRootAndFulfillBatch: a batch of 2 requests": "149525",
"unfreezeAccount": "31578",
"withdraw: 1 ether": "40539",
"withdraw: full balance": "40551",
"withdrawStake: 1 HP balance": "69007",
"withdrawStake: full balance": "52003"
}
32 changes: 20 additions & 12 deletions contracts/snapshots/BoundlessMarketBench.json
Original file line number Diff line number Diff line change
@@ -1,14 +1,22 @@
{
"fulfillBatch (with selector): batch of 001": "82552",
"fulfillBatch (with selector): batch of 002": "120073",
"fulfillBatch (with selector): batch of 004": "197004",
"fulfillBatch (with selector): batch of 008": "340588",
"fulfillBatch: batch of 001": "80444",
"fulfillBatch: batch of 002": "115891",
"fulfillBatch: batch of 004": "188569",
"fulfillBatch: batch of 008": "323764",
"fulfillBatch: batch of 016": "592831",
"fulfillBatch: batch of 032": "1150701",
"fulfillBatch: batch of 064": "2309637",
"fulfillBatch: batch of 128": "4740059"
"fulfillBatch (with callback): batch of 001": "123480",
"fulfillBatch (with callback): batch of 002": "201100",
"fulfillBatch (with callback): batch of 004": "356660",
"fulfillBatch (with callback): batch of 008": "666859",
"fulfillBatch (with callback): batch of 016": "1120918",
"fulfillBatch (with callback): batch of 032": "2059356",
"fulfillBatch (with selector): batch of 001": "83118",
"fulfillBatch (with selector): batch of 002": "120452",
"fulfillBatch (with selector): batch of 004": "196983",
"fulfillBatch (with selector): batch of 008": "339566",
"fulfillBatch (with selector): batch of 016": "624221",
"fulfillBatch (with selector): batch of 032": "1213364",
"fulfillBatch: batch of 001": "81022",
"fulfillBatch: batch of 002": "116257",
"fulfillBatch: batch of 004": "188584",
"fulfillBatch: batch of 008": "322834",
"fulfillBatch: batch of 016": "590349",
"fulfillBatch: batch of 032": "1144648",
"fulfillBatch: batch of 064": "2298563",
"fulfillBatch: batch of 128": "4717233"
}
Loading
Loading