Skip to content

Conversation

@zeroecco
Copy link
Contributor

@zeroecco zeroecco commented Dec 4, 2025

🍱 added to vscode for linting etc
🎉 valkey

@zeroecco zeroecco marked this pull request as ready for review December 4, 2025 00:59
@github-actions github-actions bot changed the title move to valkey BM-2032: move to valkey Dec 4, 2025
@austinabell
Copy link
Contributor

austinabell commented Dec 4, 2025

why duplicate of #1383 ? Also, so many unnecessary breaking changes with this, why? At least would have to make the env vars backwards compat. This also breaks if you try to upgrade with an in-progress proof in bento, when it shouldn't be necessary

@zeroecco
Copy link
Contributor Author

zeroecco commented Dec 4, 2025

why duplicate of #1383 ? Also, so many unnecessary breaking changes with this, why? At least would have to make the env vars backwards compat. This also breaks if you try to upgrade with an in-progress proof in bento, when it shouldn't be necessary

On your first point, I didn't see that PR, my bad! will close this.
whether it is now or later the naming should change to match the service. Might as well call it "cache" or "queue" or something semi app agnostic instead of "redis" or "valkey".

In the next release I want to push the default PostgreSQL version as well to major version 18 which has async IO improvements.

In progress proof failed for me on 9.0.0 and latest when redis was 7.2.x

@zeroecco zeroecco closed this Dec 4, 2025
@zeroecco zeroecco deleted the zeroecco/valkey_switch branch December 4, 2025 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants