BM-1652: [V-BND-VUL-005] add partial payment #1171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
capossele
requested review from
a team,
Wollac,
austinabell,
willemolding and
zeroecco
as code owners
github-actions
bot
changed the title
willpote
approved these changes
Sep 25, 2025
willpote
reviewed
Sep 25, 2025
| finalPrice = _applyMarketFee(finalPrice); | ||
| } | ||
| accounts[assessorProver].balance += finalPrice; | ||
| if (partialPayment) { |
There was a problem hiding this comment.
I think if finalPrice != price, it must be a partial payment, so could drop this variable
|
🚀 Documentation Preview Deployment URL: https://boundless-documentation-ngxi2irr4-boundless-network.vercel.app Updated at: 2025-10-09 13:10:35 UTC |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the
_fulfillAndPayWasLockedfunction to partially pay the prover in the case a second request with same id but different hash than the originally locked one is priced and fulfilled, and the client does not have enough balance to cover for the delta between original lockPrice and the new price.