Fix log ID check to correctly insert seen IDs #1155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The condition if !seen_log_ids.insert(info_log_id) was inverted. HashSet::insert() returns: - true if the value was not previously in the set (first time seeing this log ID) - false if the value was already in the set (seen before) Before: The warning was shown for every receipt with log ID 0, not just the first. After: The warning is shown only once per unique log ID.
derrix060
requested review from
a team,
Wollac,
austinabell,
capossele,
willemolding and
zeroecco
as code owners
austinabell
approved these changes
Sep 22, 2025
Contributor
Author
|
any news? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The condition if !seen_log_ids.insert(info_log_id) was inverted.
HashSet::insert() returns:
Before: The warning was shown for every receipt with log ID 0, not just the first.
After: The warning is shown only once per unique log ID.