-
Notifications
You must be signed in to change notification settings - Fork 53
sdk-bump, go-update, rust-update, third party package update #684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cab5968 to
943e141
Compare
943e141 to
2128274
Compare
packages/amazon-ssm-agent/0001-agent-Add-config-to-make-shell-optional.patch
Outdated
Show resolved
Hide resolved
packages/amazon-ssm-agent/0001-agent-Add-config-to-make-shell-optional.patch
Show resolved
Hide resolved
6c5c6ae to
fbced8e
Compare
fbced8e to
011f82f
Compare
ae7b021 to
6fe95b5
Compare
ad92bec to
2f11e6a
Compare
| %build | ||
| %set_cross_go_flags | ||
|
|
||
| export GO_MAJOR="1.23" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically 1.30.9 was released which bumped the package to go 1.24. But I don't think this is a blocker.
|
|
||
| %build | ||
| %cross_go_configure %{goimport} | ||
| export GO_MAJOR="1.23" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similarly here, https://github.com/containernetworking/plugins/tree/v1.8.0 bumps this to use Go 1.24.
But I don't think this is a blocker.
85bc1b3 to
9cd87d8
Compare
|
^ force pushes add -p1 to libcrypto spec file for making it explicit how patch is applied. Also, it puts back the dead code for cis check with the macro to allow dead code. |
koooosh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I prefer to combine the 2 rust lint + formatting commits, but not a blocker
|
Also, if we are updating the go version in |
9cd87d8 to
824e08f
Compare
|
Using this PR only for the required Go and Rust updates. We can work on updating |
Signed-off-by: Piyush Jena <[email protected]>
Signed-off-by: Piyush Jena <[email protected]>
Signed-off-by: Piyush Jena <[email protected]>
Signed-off-by: Piyush Jena <[email protected]>
Signed-off-by: Piyush Jena <[email protected]>
Signed-off-by: Piyush Jena <[email protected]>
824e08f to
315eae7
Compare
Description of changes:
Testing done:
Refer to bottlerocket-os/bottlerocket-sdk#298
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.