Skip to content

Conversation

@piyush-jena
Copy link
Contributor

@piyush-jena piyush-jena commented Oct 3, 2025

Description of changes:

  • Update bottlerocket-sdk to v0.65.0 (which adds support for Go-1.25 and removes support for Go-1.23)
  • Build packages with Go-1.24
  • Update aws-iam-authenticator to v0.7.8

Testing done:
Refer to bottlerocket-os/bottlerocket-sdk#298

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@piyush-jena piyush-jena force-pushed the go-updates branch 4 times, most recently from cab5968 to 943e141 Compare October 10, 2025 04:57
@piyush-jena piyush-jena marked this pull request as ready for review October 14, 2025 23:17
@piyush-jena piyush-jena force-pushed the go-updates branch 2 times, most recently from ae7b021 to 6fe95b5 Compare October 15, 2025 05:45
@piyush-jena piyush-jena changed the title Go updates sdk-bump, go-update, rust-update Oct 15, 2025
@piyush-jena piyush-jena changed the title sdk-bump, go-update, rust-update sdk-bump, go-update, rust-update, third party package update Oct 15, 2025
@piyush-jena piyush-jena force-pushed the go-updates branch 2 times, most recently from ad92bec to 2f11e6a Compare October 15, 2025 18:12
%build
%set_cross_go_flags

export GO_MAJOR="1.23"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically 1.30.9 was released which bumped the package to go 1.24. But I don't think this is a blocker.


%build
%cross_go_configure %{goimport}
export GO_MAJOR="1.23"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly here, https://github.com/containernetworking/plugins/tree/v1.8.0 bumps this to use Go 1.24.
But I don't think this is a blocker.

@piyush-jena piyush-jena force-pushed the go-updates branch 2 times, most recently from 85bc1b3 to 9cd87d8 Compare October 15, 2025 21:50
@piyush-jena
Copy link
Contributor Author

^ force pushes add -p1 to libcrypto spec file for making it explicit how patch is applied. Also, it puts back the dead code for cis check with the macro to allow dead code.

Copy link
Contributor

@koooosh koooosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I prefer to combine the 2 rust lint + formatting commits, but not a blocker

@koooosh
Copy link
Contributor

koooosh commented Oct 15, 2025

Also, if we are updating the go version in ecs-gpu-init, should we also do host-ctr: https://github.com/bottlerocket-os/bottlerocket-core-kit/blob/develop/sources/host-ctr/go.mod#L3 ?

@piyush-jena
Copy link
Contributor Author

Using this PR only for the required Go and Rust updates. We can work on updating host-ctr separately.

@KCSesh KCSesh self-requested a review October 15, 2025 23:27
@piyush-jena piyush-jena merged commit df69953 into bottlerocket-os:develop Oct 16, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants