Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set_proxy_url method #5

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

set_proxy_url method #5

wants to merge 3 commits into from

Conversation

RomneyDa
Copy link

@RomneyDa RomneyDa commented Dec 1, 2022

Simple set_proxy_url("https://your_proxy.....") method to be able to update the url that requests are sent to.
Uses existing MIXPANEL_API_URL as default

@FabianMeul FabianMeul requested a review from a team March 17, 2023 11:15
JaccoGoris
JaccoGoris approved these changes Mar 17, 2023
View reviewed changes
Copy link

@JaccoGoris JaccoGoris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great thanks! but our coding style doesn't really use underscores for function names

@thgh
Copy link
Member

thgh commented Mar 17, 2023 •
edited
Loading

This looks great thanks! but our coding style doesn't really use underscores for function names

It is appropriate in this context as this is a fork of benawad's library which uses underscores (as does the mixpanel API).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabianMeul FabianMeul FabianMeul approved these changes

@thgh thgh thgh approved these changes

@codinsonn codinsonn codinsonn approved these changes

@JaccoGoris JaccoGoris JaccoGoris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@RomneyDa @thgh @FabianMeul @codinsonn @JaccoGoris