Draft
Conversation
Previously, when a user tried to export a list of fields containing
some that did not exist on the Odoo model, the process would log a
warning but then fail later with an `IndexError` or a Polars
`InvalidOperationError`.
This commit fixes the issue by implementing the following changes:
1. In `_initialize_export`, non-existent fields are now identified and
marked with a special type `non_existent` in the `fields_info`
dictionary.
2. In `_execute_batch`, fields marked as `non_existent` are now
skipped and not included in the `read` call to the Odoo server.
3. In `_format_batch_results`, the logic now correctly handles these
skipped fields, creating columns with `None` values for them in
the final output.
4. A defensive check has been added to `_format_batch_results` to
prevent `IndexError` on malformed relational data, making the
export process more robust.
A new unit test has been added to ensure that exporting with
non-existent fields completes successfully and produces the expected
output with empty columns, preventing future regressions.
Author
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll acknowledge your comments with a 👀 emoji and then get to work. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! I will automatically address your feedback. For any comments you don't want me to act on, just include (aside). For security, I will only act on instructions from the user who triggered this task for this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20
PR created automatically by Jules for task 17503628540587904004