-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MAINTAINERS.md and ADOPTERS.md #843
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possibly the nittiest review I've ever given. Looks good to me on the whole, just some small grammatical stuff that doesn't affect the message of the PR in any way.
If my suggestions are too nitty/unnecessary please let me know and I will approve this
|
||
**End-user**: The organization runs bootc in production in some way. | ||
|
||
**Integration**: The organization has a product that integrates with bootc, but does not contain bootc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More nits: Would integrator
make more grammatical sense than integration
here? In the context of using end-user
and vendor
as the other options
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm could be but I was basing this on e.g. https://github.com/kubevirt/kubevirt/blob/main/ADOPTERS.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, that makes sense, I thought it was odd how the verbiage switches up. I will approve momentarily
These files help clarify/formalize some information. In particular I'd like to look at tools that auto-sync from MAINTAINERS to the github permissions so that we can maintain that in a git-ops fashion. Signed-off-by: Colin Walters <[email protected]>
588fd73
to
ddbdfba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
These files help clarify/formalize some information. In particular I'd like to look at tools that auto-sync from MAINTAINERS to the github permissions so that we can maintain that in a git-ops fashion.