-
Notifications
You must be signed in to change notification settings - Fork 137
WIP: examples: Add bootc UKI & BLS examples #1617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
||
[features] | ||
default = ["install-to-disk"] | ||
default = ["install-to-disk", "composefs-backend"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine for WIP (I know for example this makes rust-analyzer annoying to work with without it), but we probably don't want to enable this by default quite yet, even though adding these tests goes a long way to increasing our confidence. Maybe let it bake in CI and get early community feedback for a release or two before we turn it on?
&format!("{transport}{image_name}"), | ||
None, | ||
None, | ||
Some(ostree_ext::containers_image_proxy::ImageProxyConfig { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this required? Looking at SourceInfo
the docs at least claim to always use containers-storage
. Either I'm misunderstanding the flow here (very possible!) or there's a mismatch between the docs and what is actually happening.
} | ||
|
||
println!("state: {state:#?}"); | ||
println!("root_setup: {rootfs:#?}"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine for WIP just wanted to note here to remove these (plus one more below) before final merge
15556ec
to
d83dffc
Compare
Agree that we do not want to merge this PR as is right now. This is more place to share progress and the developments scripts we are currently using. |
d83dffc
to
e07b165
Compare
/// See https://github.com/containers/composefs-rs/issues/159 | ||
// pub type ComposefsRepository = | ||
// composefs::repository::Repository<composefs::fsverity::Sha512HashValue>; | ||
pub type ComposefsRepository = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per #1190 I think we should change all of the code to use this alias instead
// composefs::repository::Repository<composefs::fsverity::Sha512HashValue>; | ||
pub type ComposefsRepository = | ||
composefs::repository::Repository<composefs::fsverity::Sha512HashValue>; | ||
composefs::repository::Repository<composefs::fsverity::Sha256HashValue>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And consensus seems to be keeping sha512
6126ae9
to
f3dc163
Compare
f3dc163
to
9b17841
Compare
3fb6f48
to
3e7e6dd
Compare
This is in prep for adding config files for BLS compliant bootloaders booting via UKI. Adds a field `cfg_type` to BLSConfig which will contain either of the following sets of keys: cfg_type - NonEFI - linux - initrd - options or cfg_type - EFI - efi Signed-off-by: Pragyan Poudyal <[email protected]>
We did not have config files for systemd-boot and were only using UKIs which did not allow proper sorting of the UKIs. This adds .conf files to `$ESP/loader/entries` Also, preserves UKI addons' names so we don't overwrite previously added addon Signed-off-by: Pragyan Poudyal <[email protected]>
Signed-off-by: Pragyan Poudyal <[email protected]>
Add logic for upgrading/switching to a deployment with systemd-boot as the bootloader. Also update finalize-staged service to handle systemd-boot bootloader entries for UKIs Signed-off-by: Pragyan Poudyal <[email protected]>
Allows installing only some of the addons depending upon the list of addons passed in as cli options. Signed-off-by: Pragyan Poudyal <[email protected]>
skopeo (in composefs-rs) doesn't understand the transport "registry:", so we convert it to "docker://" when passing it to skopeo Signed-off-by: Pragyan Poudyal <[email protected]>
Co-Authored-By: Pragyan Poudyal <[email protected]> Co-Authored-By: John Eckersberg <[email protected]> Signed-off-by: Timothée Ravier <[email protected]>
488bc5e
to
94a53f0
Compare
Work in progress for #1614