generator: Conditionally enable bootc-status units #1610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly prevents the bootc-publish-rhsm-facts.service from running on non-bootc systems by adding the ConditionPathExists=/run/ostree-booted check. This will fix failures on systems that have subscription-manager but are not managed by bootc. The change is logical and aligns with how other bootc services are conditioned. I have one suggestion to improve the maintainability of a TODO comment that was added.
Right now this service fails in `bcvk run-ephemeral`, but also likely fails in any non-bootc system that has `subscription-manager` installed. A problem is that dependencies of units are started even if the dependee has a condition that disables it. This basically the target and path depend on `/run/ostree-booted` being present (which yes, won't work for composefs...) Tests: Covered by extant `012-test-unit-status.nu` Signed-off-by: Colin Walters <[email protected]>
cgwalters
force-pushed
the
bootc-publish-condition
branch
from
349f9c4 to
e3f216d
Compare
cgwalters
changed the title
|
OK I reworked this more deeply. |
cgwalters
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now this service fails in
bcvk run-ephemeral, butalso likely fails in any non-bootc system that has
subscription-managerinstalled.
A problem is that dependencies of units are started even
if the dependee has a condition that disables it.
This basically the target and path depend on
/run/ostree-bootedbeing present (which yes, won't work for composefs...)
Tests: Covered by extant
012-test-unit-status.nu