Skip to content

[BOT] Bump Velox version#704

Merged
zhztheplayer merged 2 commits into
mainfrom
bump-velox-509
Jun 24, 2026
Merged

[BOT] Bump Velox version#704
zhztheplayer merged 2 commits into
mainfrom
bump-velox-509

Conversation

@velox4j-bot

@velox4j-bot velox4j-bot Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Update Velox to latest. Diff: facebookincubator/velox@5a397b2...e603dc1

@velox4j-bot velox4j-bot Bot enabled auto-merge (squash) June 24, 2026 07:40
@zhztheplayer

Copy link
Copy Markdown
Contributor

@copilot check CI

auto-merge was automatically disabled June 24, 2026 08:23

Head branch was pushed to by a user without write access

Copilot AI commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

@copilot check CI

Both CI jobs (C++ UT and Java UT) failed with the same error:

fatal error: velox/dwio/parquet/writer/WriterConfig.h: No such file or directory

This header was removed in the new Velox version (e603dc1). The WriterConfig struct (and its kParquetHiveConnectorWriteTimestampUnit constant) has been superseded by ParquetConfig in velox/dwio/parquet/common/ParquetConfig.h.

Fixed in commit Fix: replace removed WriterConfig.h with ParquetConfig.h in Init.cc by:

  • Replacing #include <velox/dwio/parquet/writer/WriterConfig.h>#include <velox/dwio/parquet/common/ParquetConfig.h>
  • Replacing parquet::WriterConfig::kParquetHiveConnectorWriteTimestampUnit"hive.parquet." + std::string(parquet::ParquetConfig::kWriterTimestampUnit) (both resolve to "hive.parquet.writer.timestamp-unit")

Copilot AI requested a review from zhztheplayer June 24, 2026 08:23
@zhztheplayer zhztheplayer merged commit 831cdcd into main Jun 24, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants