-
Notifications
You must be signed in to change notification settings - Fork 149
fix(lifetime): extending the lifetime of temporary objects #160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
amitsingh19975
wants to merge
18
commits into
develop
Choose a base branch
from
bugfix/lifetime
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
15c4476
fix(lifetime): extending the lifetime of temporary objects
amitsingh19975 8f5a5d1
fix(comparision): use `same_exp` instead of `std::is_same`
amitsingh19975 8178c6c
refactor(comparision): decoupled `if constexpr` and cleaned-up compare.
amitsingh19975 9b8c4e1
test(enable): enable tests for expression templates
amitsingh19975 d70a701
fix(test): bind the prvalue (=3) to a variable
amitsingh19975 8ec747c
refactor(expression): add function cast_tensor_expression for casting
amitsingh19975 7a936dd
chore(expression): add `nodiscard`
amitsingh19975 b6a3dd8
refactor(comparision): remove the construction of a whole new tensor
amitsingh19975 3a013d0
fix(compare): get the value type after `cast_tensor_expression`
amitsingh19975 7b23092
refactor(expression): validate predicate and add noexcept
amitsingh19975 a90573c
refactor(eval): clean the implementation
amitsingh19975 2abe215
fix(expression): disable the move constructor for public use to avoid…
amitsingh19975 51674d5
refactor(expression): clean unnecessary code and fix the comparision …
amitsingh19975 b7de038
refactor(expression): use `std::invoke` and add types to functional o…
amitsingh19975 bc0afbd
refactor(expression): add `noexcept`, rearrange constructors, and rem…
amitsingh19975 00357a0
fix(test): remove the undefined behaviour if the type is not FP
amitsingh19975 549f8a0
refactor(expression): improve error message and simplified if-else.
amitsingh19975 23ba8fc
refactor(compare): combine two compare function into one for easier m…
amitsingh19975 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.