Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] API 요청 시 bearer token 제거 및 로그인/비로그인 처리 변경 #445

Merged
merged 15 commits into from
Dec 12, 2023
Merged

[Refactor] API 요청 시 bearer token 제거 및 로그인/비로그인 처리 변경 #445

merged 15 commits into from
Dec 12, 2023

Conversation

ttaerrim
Copy link
Member

@ttaerrim ttaerrim commented Dec 12, 2023 •
edited
Loading

설명

완료한 기능 명세

  • 프론트엔드 로그인 안 한 유저의 라우터 진입 방지 코드 수정
  • API 요청 시 bearer token 넣지 않도록 수정

스크린샷

기능 작업에 대한 스크린샷/화면 녹화 있을 경우 첨부하기

리뷰 요청 사항

특별히 리뷰해 주었으면 하는 부분, 고민되는 부분 기재하기

@ttaerrim ttaerrim self-assigned this Dec 12, 2023
@ttaerrim ttaerrim changed the title 440 auth 2 [Refactor] API 요청 시 bearer token 제거 및 로그인/비로그인 처리 변경 Dec 12, 2023
@ttaerrim ttaerrim added ✨ enhancement 개선 또는 피드백 반영 🎨 Front-end ✅ Test labels Dec 12, 2023
@ttaerrim ttaerrim marked this pull request as ready for review December 12, 2023 07:38
ldhbenecia
ldhbenecia approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@ldhbenecia ldhbenecia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p3: LGTM

@ttaerrim ttaerrim merged commit dfe0ea4 into boostcampwm2023:feature/auth-refactor Dec 12, 2023
@ttaerrim ttaerrim deleted the 440-auth-2 branch December 12, 2023 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldhbenecia ldhbenecia ldhbenecia approved these changes

@LEEJW1953 LEEJW1953 Awaiting requested review from LEEJW1953

@js43o js43o Awaiting requested review from js43o

Assignees

@ttaerrim ttaerrim

Labels
✨ enhancement 개선 또는 피드백 반영 🎨 Front-end ✅ Test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ttaerrim @ldhbenecia