refactor: 에러 로깅 상수, 함수 분리 #93

boostcampwm-2024 · Nov 14, 2024 · 3547c19 · 3547c19
1 parent a6c5c62
commit 3547c19
Showing 1 changed file with 12 additions and 10 deletions.
diff --git a/backend/src/common/exception/filter/GlobalExceptionFilter.ts b/backend/src/common/exception/filter/GlobalExceptionFilter.ts
@@ -18,11 +18,7 @@ export class BaseExceptionFilter implements ExceptionFilter {
     const response = ctx.getResponse<Response>();
 
     const status = exception.getStatus();
-    if (status >= 400 && status < 500) {
-      this.logger.warn(`${exception.getMessage()}`);
-    } else if (status >= 500) {
-      this.logger.error(`${exception.getMessage()}`);
-    }
+    logException(this.logger, exception.getMessage(), status);
 
     return response.status(status).json({
       code: exception.getCode(),
@@ -45,11 +41,7 @@ export class HttpExceptionFilter implements ExceptionFilter {
       : exception.message;
 
     const status = exception.getStatus();
-    if (status >= 400 && status < 500) {
-      this.logger.warn(`${errorMessage}`);
-    } else if (status >= 500) {
-      this.logger.error(`${errorMessage}`);
-    }
+    logException(this.logger, errorMessage, status);
 
     return response.status(status).json({
       code: 9999,
@@ -67,6 +59,16 @@ export class HttpExceptionFilter implements ExceptionFilter {
   }
 }
 
+function logException(logger: PinoLogger, message: string, status: number) {
+  const WARN = 400;
+  const ERROR = 500;
+
+  if (status < WARN) return;
+  void (status < ERROR
+    ? logger.warn(`${message}`)
+    : logger.error(`${message}`));
+}
+
 @Catch()
 export class UnknownExceptionFilter implements ExceptionFilter {
   constructor(private readonly logger: PinoLogger) {}