Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fe): propagate error in useSignInForm hook #90

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

cjeongmin
Copy link
Collaborator

개요

  • 에러가 전파되지 않아 UI가 업데이트되지 않던 문제를 수정했습니다.

@cjeongmin cjeongmin added the Fix label Nov 14, 2024
@cjeongmin cjeongmin self-assigned this Nov 14, 2024
Copy link
Collaborator

@yu-yj215 yu-yj215 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@wlgh1553 wlgh1553 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@cjeongmin cjeongmin merged commit 156f8b9 into main Nov 14, 2024
1 check passed
@cjeongmin cjeongmin deleted the fix(fe)/propagate-error branch November 14, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants