Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(fe): add modal management context and custom hook #26

Merged
merged 5 commits into from
Nov 7, 2024
Merged

feat(fe): add modal management context and custom hook #26

merged 5 commits into from
Nov 7, 2024

Conversation

cjeongmin
Copy link
Collaborator

@cjeongmin cjeongmin commented Nov 6, 2024 •
edited
Loading

개요

  • 모달을 사용하기 위해 아래 내용을 추가했습니다.
    • 모달을 관리하는 Context 추가
    • 모달을 생성하고 접근할 수 있는 커스텀 훅 추가
  • 브랜치 이름에 괄호를 추가하여, 깃헙 액션에 오류가 발생하여 해당 부분 수정합니다.

이슈

@cjeongmin cjeongmin added the Feature New feature or request label Nov 6, 2024
@cjeongmin cjeongmin self-assigned this Nov 6, 2024
@cjeongmin cjeongmin changed the title feat: add modal management context and custom hook feat(fe): add modal management context and custom hook Nov 6, 2024
@boostcampwm-2024 boostcampwm-2024 locked and limited conversation to collaborators Nov 6, 2024
@boostcampwm-2024 boostcampwm-2024 unlocked this conversation Nov 6, 2024
@cjeongmin cjeongmin marked this pull request as draft November 6, 2024 17:20
@cjeongmin cjeongmin marked this pull request as ready for review November 7, 2024 00:59
wlgh1553
wlgh1553 approved these changes Nov 7, 2024
View reviewed changes
Copy link
Collaborator

@wlgh1553 wlgh1553 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!
이런 게 커스텀 훅이군요! 배워갑니다👍👍

@cjeongmin cjeongmin merged commit 7e03ca5 into main Nov 7, 2024
1 check passed
@cjeongmin cjeongmin deleted the feat(fe)/modal branch November 7, 2024 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wlgh1553 wlgh1553 wlgh1553 approved these changes

@yu-yj215 yu-yj215 yu-yj215 approved these changes

@shl0501 shl0501 Awaiting requested review from shl0501

Assignees

@cjeongmin cjeongmin

Labels
Feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feat]: Modal hook 구현
3 participants
@cjeongmin @wlgh1553 @yu-yj215