Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(be): separate socket server #250

Merged
merged 4 commits into from
Dec 3, 2024
Merged

feat(be): separate socket server #250

merged 4 commits into from
Dec 3, 2024

Conversation

yu-yj215
Copy link
Collaborator

@yu-yj215 yu-yj215 commented Dec 3, 2024

개요

  • 소켓과 API를 pm2를 이용해서 두 개로 분리했습니다.

이슈

@yu-yj215 yu-yj215 added the Feature New feature or request label Dec 3, 2024
shl0501
shl0501 previously approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@shl0501 shl0501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

wlgh1553
wlgh1553 previously approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@wlgh1553 wlgh1553 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!!

@github-actions github-actions bot dismissed stale reviews from wlgh1553 and shl0501 via 1fc849e December 3, 2024 09:16
@wlgh1553 wlgh1553 requested review from wlgh1553 and shl0501 December 3, 2024 09:20
wlgh1553
wlgh1553 previously approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@wlgh1553 wlgh1553 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm1!!

shl0501
shl0501 previously approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@shl0501 shl0501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yu-yj215
fix: remove spec file
4ca178b
@yu-yj215
Merge remote-tracking branch 'origin/refactor(be)/separate-socket-ser…
327ff74 
…ver' into refactor(be)/separate-socket-server

# Conflicts:
#	apps/server/src/socket/socket.controller.spec.ts
@yu-yj215 yu-yj215 dismissed stale reviews from shl0501 and wlgh1553 via 327ff74 December 3, 2024 09:28
@wlgh1553 wlgh1553 requested review from shl0501 and wlgh1553 December 3, 2024 09:30
cjeongmin
cjeongmin approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@cjeongmin cjeongmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

wlgh1553
wlgh1553 approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@wlgh1553 wlgh1553 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@yu-yj215 yu-yj215 merged commit 226207a into main Dec 3, 2024
2 checks passed
@yu-yj215 yu-yj215 deleted the refactor(be)/separate-socket-server branch December 3, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wlgh1553 wlgh1553 wlgh1553 approved these changes

@cjeongmin cjeongmin cjeongmin approved these changes

@shl0501 shl0501 Awaiting requested review from shl0501

Assignees

@wlgh1553 wlgh1553

@yu-yj215 yu-yj215

@shl0501 shl0501

Labels
Feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feat]: socket 서버 분리
4 participants
@yu-yj215 @cjeongmin @wlgh1553 @shl0501