Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(fe): add toggle for hiding expired sessions #246

Merged
merged 4 commits into from
Dec 3, 2024
Merged

feat(fe): add toggle for hiding expired sessions #246

merged 4 commits into from
Dec 3, 2024

Conversation

cjeongmin
Copy link
Collaborator

@cjeongmin cjeongmin commented Dec 3, 2024 •
edited
Loading

개요

  • 만료된 세션 숨기기 / 보이기 토글 기능을 추가했습니다.
  • 세션 화면에서 현재 세션이 만료되었는지, 진행 중인지 확인할 수 있습니다.
  • 테스트
    • 세션 목록에서 토글 처리
    • 세션 화면에서 만료 여부 확인
image image image

이슈

@cjeongmin cjeongmin added the Feature New feature or request label Dec 3, 2024
@cjeongmin cjeongmin self-assigned this Dec 3, 2024
@cjeongmin cjeongmin requested a review from Copilot December 3, 2024 07:46
@cjeongmin cjeongmin marked this pull request as draft December 3, 2024 07:46
shl0501
shl0501 previously approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@shl0501 shl0501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lGtM

Copilot
Copilot AI reviewed Dec 3, 2024
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 5 changed files in this pull request and generated no suggestions.
@cjeongmin cjeongmin requested a review from shl0501 December 3, 2024 07:57
@cjeongmin cjeongmin marked this pull request as ready for review December 3, 2024 07:57
wlgh1553
wlgh1553 approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@wlgh1553 wlgh1553 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!!! 고생하셨습니다.

shl0501
shl0501 approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@shl0501 shl0501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cjeongmin cjeongmin merged commit 42e0049 into main Dec 3, 2024
2 checks passed
@cjeongmin cjeongmin deleted the feat(fe)/session-filter branch December 3, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@wlgh1553 wlgh1553 wlgh1553 approved these changes

@shl0501 shl0501 shl0501 approved these changes

@yu-yj215 yu-yj215 Awaiting requested review from yu-yj215

Assignees

@cjeongmin cjeongmin

Labels
Feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feat]: 세션 목록 만료 여부 토글, 세션 내 만료 여부 확인 추가
3 participants
@cjeongmin @wlgh1553 @shl0501