Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fe): change styles #223

Merged
merged 5 commits into from
Nov 28, 2024
Merged

feat(fe): change styles #223

merged 5 commits into from
Nov 28, 2024

Conversation

cjeongmin
Copy link
Collaborator

개요

  • 세션 종료 버튼의 색상을 수정했습니다.
  • 질문과 답변이 비어있는 경우 UI를 추가했습니다.
  • 질문과 답변 삭제시, 모달을 통해 다시 한 번 확인 받도록 수정했습니다.
  • 세션 종료시 소켓 연결을 끊도록 수정했습니다.

이슈

@cjeongmin cjeongmin added the Feature New feature or request label Nov 28, 2024
@cjeongmin cjeongmin self-assigned this Nov 28, 2024
@cjeongmin cjeongmin requested a review from Copilot November 28, 2024 06:22
Copy link
Collaborator

@wlgh1553 wlgh1553 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!! 고생하셨습니다!

Copy link
Collaborator

@yu-yj215 yu-yj215 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

엘지티엠

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 7 changed files in this pull request and generated no suggestions.

Files not reviewed (2)
  • apps/client/src/components/modal/DeleteConfirmModal.tsx: Evaluated as low risk
  • apps/client/src/components/qna/QuestionDetail.tsx: Evaluated as low risk
Comments skipped due to low confidence (2)

apps/client/src/components/qna/ReplyItem.tsx:121

  • The function call can be simplified to onConfirm={handleDelete}.
<DeleteConfirmModal onConfirm={() => handleDelete()} />

apps/client/src/components/qna/QuestionList.tsx:106

  • Ensure that the 'key' property is unique for each button to avoid potential issues with React's key prop.
key: '공유',
@cjeongmin cjeongmin merged commit 914020a into main Nov 28, 2024
1 check passed
@cjeongmin cjeongmin deleted the feat(fe)/ui branch November 28, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat]: 일부 누락된 UI 추가
3 participants