Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fe): include userId in reply addition for CreateReplyModal #217

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

cjeongmin
Copy link
Collaborator

개요

  • 빌드 에러를 수정했습니다.
    • 기존 optional 조건을, nullable로 변경 후 null을 포함하지 않은 오류가 발생하여 추가했습니다.

진짜 핫픽스라 없슈

@cjeongmin cjeongmin added the Fix label Nov 28, 2024
@cjeongmin cjeongmin self-assigned this Nov 28, 2024
@cjeongmin cjeongmin requested a review from Copilot November 28, 2024 04:35

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.

Comments skipped due to low confidence (1)

apps/client/src/components/modal/CreateReplyModal.tsx:39

  • Ensure that the behavior of setting userId to null is covered by tests.
userId: null,
Copy link
Collaborator

@wlgh1553 wlgh1553 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm~!

Copy link
Collaborator

@shl0501 shl0501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@cjeongmin cjeongmin merged commit 4090068 into main Nov 28, 2024
1 check passed
@cjeongmin cjeongmin deleted the fix(fe)/type-error branch November 28, 2024 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants