Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(fe): improve code quality using SonarLint, SonarQube #52

Merged
merged 8 commits into from
Jan 25, 2025

Conversation

cjeongmin
Copy link
Contributor

개요

SonarQube, SonarLint 이용하여 코드 품질 개선을 진행했습니다.

  • 컴포넌트의 Props를 읽기 전용으로 변경
  • 함수 중첩 제거
  • 웹 접근성 개선
  • 기본 내장 메서드 다른 메서드로 변경
  • 컴포넌트 분리
  • Prmoise.reject로 넘겨지는 값 에러로 변환
개선 전 개선 후
image image
image image
  • SonarLint 적용 후, 린트 에러는 47건에서 0건으로 감소하였습니다. (100% 감소).
  • SonarQube 분석 후, 클라이언트 측 이슈만 처리하여 전체 이슈 75건에서 17건으로 감소하였습니다. (약 77% 감소).

이슈

@cjeongmin cjeongmin self-assigned this Jan 25, 2025
@Copilot Copilot bot review requested due to automatic review settings January 25, 2025 03:03

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 48 out of 63 changed files in this pull request and generated no comments.

Files not reviewed (15)
  • apps/client/package.json: Language not supported
  • apps/client/src/entities/session/ui/ChattingMessage.tsx: Evaluated as low risk
  • apps/client/src/entities/session/model/session.slice.ts: Evaluated as low risk
  • apps/client/src/features/delete-question/ui/DeleteConfirmModal.tsx: Evaluated as low risk
  • apps/client/playwright.config.ts: Evaluated as low risk
  • apps/client/src/features/create-update-question/ui/CreateQuestionModal.tsx: Evaluated as low risk
  • apps/client/eslint.config.js: Evaluated as low risk
  • apps/client/src/entities/session/model/qna.slice.ts: Evaluated as low risk
  • apps/client/src/features/create-update-reply/ui/CreateReplyModal.tsx: Evaluated as low risk
  • apps/client/src/features/get-chatting-list/api/get-chatting-list.api.ts: Evaluated as low risk
  • apps/client/src/app/config/axios.config.ts: Evaluated as low risk
  • apps/client/src/features/create-update-question/ui/QuestionModalHeader.tsx: Evaluated as low risk
  • apps/client/src/features/create-update-reply/ui/ReplyModalHeader.tsx: Evaluated as low risk
  • apps/client/src/features/create-update-reply/ui/ReplyContentEditor.tsx: Evaluated as low risk
  • apps/client/src/features/create-update-question/ui/QuestionContentEditor.tsx: Evaluated as low risk
@cjeongmin cjeongmin requested a review from shl0501 January 25, 2025 03:26
@wlgh1553 wlgh1553 self-requested a review January 25, 2025 03:27
Copy link
Collaborator

@shl0501 shl0501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

최근 코드품질을 어떻게 올릴 수 있을지에 대한 고민이 많았었는데 좋은 예시 보고 갑니다
LGTM

Copy link
Contributor

@wlgh1553 wlgh1553 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

대최마의 리팩토링은 아직 끝나지 않았다.
결국 소나큐브 소나린트 성공해내셨군요ㄷㄷ
엄청난 수치네요 고생하셨습니다.

@cjeongmin cjeongmin merged commit 78bbed3 into main Jan 25, 2025
2 checks passed
@cjeongmin cjeongmin deleted the refactor(fe)/code branch January 25, 2025 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Refactor]: 코드 품질 개선
3 participants