-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(fe): improve code quality using SonarLint, SonarQube #52
Conversation
… code to not nest functions more than 4 levels deep
…and Background components
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 48 out of 63 changed files in this pull request and generated no comments.
Files not reviewed (15)
- apps/client/package.json: Language not supported
- apps/client/src/entities/session/ui/ChattingMessage.tsx: Evaluated as low risk
- apps/client/src/entities/session/model/session.slice.ts: Evaluated as low risk
- apps/client/src/features/delete-question/ui/DeleteConfirmModal.tsx: Evaluated as low risk
- apps/client/playwright.config.ts: Evaluated as low risk
- apps/client/src/features/create-update-question/ui/CreateQuestionModal.tsx: Evaluated as low risk
- apps/client/eslint.config.js: Evaluated as low risk
- apps/client/src/entities/session/model/qna.slice.ts: Evaluated as low risk
- apps/client/src/features/create-update-reply/ui/CreateReplyModal.tsx: Evaluated as low risk
- apps/client/src/features/get-chatting-list/api/get-chatting-list.api.ts: Evaluated as low risk
- apps/client/src/app/config/axios.config.ts: Evaluated as low risk
- apps/client/src/features/create-update-question/ui/QuestionModalHeader.tsx: Evaluated as low risk
- apps/client/src/features/create-update-reply/ui/ReplyModalHeader.tsx: Evaluated as low risk
- apps/client/src/features/create-update-reply/ui/ReplyContentEditor.tsx: Evaluated as low risk
- apps/client/src/features/create-update-question/ui/QuestionContentEditor.tsx: Evaluated as low risk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
최근 코드품질을 어떻게 올릴 수 있을지에 대한 고민이 많았었는데 좋은 예시 보고 갑니다
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
대최마의 리팩토링은 아직 끝나지 않았다.
결국 소나큐브 소나린트 성공해내셨군요ㄷㄷ
엄청난 수치네요 고생하셨습니다.
개요
SonarQube, SonarLint 이용하여 코드 품질 개선을 진행했습니다.
이슈