Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(fe): split QuestionItem, ReplyItem components into multiple files #48

Merged
merged 3 commits into from
Jan 24, 2025

Conversation

cjeongmin
Copy link
Contributor

개요

  • QuestionItem, ReplyItem 컴포넌트의 복잡도가 높다고 판단되어 해당 컴포넌트를 여러 파일로 나누어 복잡도를 낮추는 작업을 진행했습니다.

이슈

@cjeongmin cjeongmin self-assigned this Jan 23, 2025
@Copilot Copilot bot review requested due to automatic review settings January 23, 2025 09:42

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 17 changed files in this pull request and generated no comments.

Files not reviewed (12)
  • apps/client/src/widgets/question-list/ui/QuestionItem.tsx: Evaluated as low risk
  • apps/client/src/widgets/reply-list/ui/ReplyItem.tsx: Evaluated as low risk
  • apps/client/src/widgets/reply-list/ui/ReplyDeleteButton.tsx: Evaluated as low risk
  • apps/client/src/widgets/reply-list/ui/ReplyBody.tsx: Evaluated as low risk
  • apps/client/src/widgets/question-list/model/useQuestionActions.ts: Evaluated as low risk
  • apps/client/src/widgets/question-list/ui/QuestionDeleteButton.tsx: Evaluated as low risk
  • apps/client/src/widgets/reply-list/ui/ReplyEditButton.tsx: Evaluated as low risk
  • apps/client/src/widgets/question-list/ui/QuestionLikeButton.tsx: Evaluated as low risk
  • apps/client/src/widgets/question-list/ui/QuestionEditButton.tsx: Evaluated as low risk
  • apps/client/src/widgets/question-list/ui/ReplyCountButton.tsx: Evaluated as low risk
  • apps/client/src/widgets/reply-list/model/useReplyActions.ts: Evaluated as low risk
  • apps/client/src/widgets/reply-list/ui/ReplyHeader.tsx: Evaluated as low risk
Copy link
Contributor

@wlgh1553 wlgh1553 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question과 reply를 model과 ui로 분리하셨군요!!
ui로 작게 작게 나누고 model엔 액션 위주로 들어가서 복잡도가 많이 줄었네요~!
퇴근 후에도 고생하셨습니다 OJL

Copy link
Collaborator

@shl0501 shl0501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

최근 model과 ui 의 구분에 대한 고민이 많았는데, 너무 좋은 예시를 보고 갑니다.
LGTM

@cjeongmin cjeongmin merged commit 1bb1628 into main Jan 24, 2025
2 checks passed
@cjeongmin cjeongmin deleted the refactor(fe)/readability branch January 24, 2025 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Refactor]: QuestionItem, ReplyItem 컴포넌트 분리
3 participants