[WIP] Add binary repair photometry ordering#479
Open
antoine-le-calloch wants to merge 5 commits into
Open
Conversation
… available to batch the scan.
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a maintenance binary to scan survey aux collections and repair photometry time-series arrays so they are ordered and deduplicated by jd.
Changes:
- Adds
repair_photometry_orderingbinary with survey selection, batching, partitioned scanning, dry-run mode, and bulk update repair logic. - Adds shared CLI parsing/progress-bar helpers.
- Includes the new binary in container images.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/bin/repair_photometry_ordering.rs |
Implements the photometry ordering repair tool. |
src/utils/parser.rs |
Adds a positive usize parser for CLI arguments. |
src/utils/mod.rs |
Exposes the parser utility module. |
src/utils/data.rs |
Adds a shared progress-bar helper. |
Dockerfile |
Copies the repair binary into the app image. |
Dockerfile.gpu |
Builds and copies the repair binary into the GPU image. |
Cargo.toml |
Adds a new dependency. |
Cargo.lock |
Locks the new dependency and transitive packages. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+406
to
+408
| Err(e) => { | ||
| error!("partition join failed: {}", e); | ||
| } |
| apache-avro = { version = "0.21.0", features = ["snappy", "derive"] } | ||
| apache-avro-derive = "0.21.0" | ||
| apache-avro-macros = { version = "1", path = "apache-avro-macros" } | ||
| async-channel = "2.5.0" |
antoine-le-calloch
changed the title
|
Throughput results (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.