Only log passing filter#465
Conversation
…e doc pass the filter.
There was a problem hiding this comment.
Pull request overview
This PR updates ZTF filter processing so the "passed filter" log line is only emitted when at least one document actually passes the filter, reducing misleading/zero-count log noise during normal operations.
Changes:
- Skip per-filter processing early when
out_documentsis empty. - Move the
"passed filter"info!log to occur only after confirming there are output documents to process.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@antoine-le-calloch one thing to take note of: the throughput test relies on filter logs (which should be the last that are logged in the app) to get the timestamp of the end of processing, so we can compute the wall time. My suggestion would be to log everytime but at the debug level, and make sure the throughput test sets the log level to debug. That way no problem for production (where I doubt you have the log level set to debug) nor throughput testing/development? |
Ohh yeah nice catch, sorry for that. |
Update filter processing to log "passed filter" only when at least one doc pass the filter.