Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edge driver url #1323

Merged
merged 4 commits into from
Jul 30, 2024
Merged

Edge driver url #1323

merged 4 commits into from
Jul 30, 2024

Conversation

rdmrtn
Copy link
Contributor

@rdmrtn rdmrtn commented Jul 22, 2024

Purpose of changes

MicrosoftEdge/EdgeWebDriver#146

Types of changes

  • Bug-fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How has this been tested?

[main] INFO io.github.bonigarcia.wdm.WebDriverManager - Using WebDriverManager to resolve edge
[main] INFO io.github.bonigarcia.wdm.WebDriverManager - Using msedgedriver 125.0.2535.92 (resolved driver for Edge 125)
[main] INFO io.github.bonigarcia.wdm.WebDriverManager - Reading https://msedgewebdriverstorage.blob.core.windows.net/edgewebdriver/?restype=container&comp=list to seek msedgedriver
[main] INFO io.github.bonigarcia.wdm.WebDriverManager - Reading https://msedgewebdriverstorage.blob.core.windows.net/edgewebdriver/?restype=container&comp=list&marker=2%21104%21MDAwMDMzITEyNC4wLjI0NzcuMC9lZGdlZHJpdmVyX3dpbjY0LnppcCEwMDAwMjghOTk5OS0xMi0zMVQyMzo1OTo1OS45OTk5OTk5WiE- to seek msedgedriver
[main] INFO io.github.bonigarcia.wdm.online.Downloader - Downloading https://msedgewebdriverstorage.blob.core.windows.net/edgewebdriver/125.0.2535.92/edgedriver_linux64.zip
[main] INFO io.github.bonigarcia.wdm.online.Downloader - Extracting driver from compressed file edgedriver_linux64.zip
[main] INFO io.github.bonigarcia.wdm.WebDriverManager - Driver location: /home/eartan/Projects/visiumgo/webdrivermanager/msedgedriver

@rdmrtn rdmrtn closed this Jul 22, 2024
@rdmrtn rdmrtn reopened this Jul 22, 2024
@bonigarcia
Copy link
Owner

I believe this PR is no longer required. There was a bug related to msedgedriver (#1320) but it has been fixed in the master branch. Please double check the latest release of WebDriverManager, i.e. version 5.9.2.

@rdmrtn
Copy link
Contributor Author

rdmrtn commented Jul 30, 2024

I do not understand why it is no longer required.
When getDriversFromXml (

protected List<URL> getDriversFromXml(URL driverUrl, String xpath,
) is called, it will not get latest driver information because Azure Blob Storage requires marker parameter to fetch all pages.

#1320 is similar but not same issue.

@bonigarcia
Copy link
Owner

That logic (reading from XML to discover edgedriver versions) should not be executed since the driver versions should be found using the online endpoints, e.g., https://msedgedriver.azureedge.net/LATEST_RELEASE_127_WINDOWS

So, I have just committed a patch to avoid that logic in the Edge Manager class: f6263e8

Also, you should not change the value of the property wdm.edgeDriverUrl. And your code does not even compile:

https://github.com/bonigarcia/webdrivermanager/actions/runs/10039350820/job/27920720228?pr=1323

Error:  COMPILATION ERROR : 
[1822](https://github.com/bonigarcia/webdrivermanager/actions/runs/10039350820/job/27920720228?pr=1323#step:5:1823)[INFO] -------------------------------------------------------------
[1823](https://github.com/bonigarcia/webdrivermanager/actions/runs/10039350820/job/27920720228?pr=1323#step:5:1824)Error:  /home/runner/work/webdrivermanager/webdrivermanager/src/main/java/io/github/bonigarcia/wdm/WebDriverManager.java:[1594,63] cannot find symbol
[1824](https://github.com/bonigarcia/webdrivermanager/actions/runs/10039350820/job/27920720228?pr=1323#step:5:1825) symbol:   class URIBuilder
[1825](https://github.com/bonigarcia/webdrivermanager/actions/runs/10039350820/job/27920720228?pr=1323#step:5:1826) location: class io.github.bonigarcia.wdm.WebDriverManager

Many thanks for your effort but I cannot merge this PR.

@bonigarcia bonigarcia closed this Jul 30, 2024
@bonigarcia
Copy link
Owner

After further investigation, I realized that reading the Edge driver versions from XML can still be helpful in some cases. So please resolve the compilation failures, and I will merge this PR.

@bonigarcia bonigarcia reopened this Jul 30, 2024
@rdmrtn
Copy link
Contributor Author

rdmrtn commented Jul 30, 2024

I've fixed the problem. Thanks.

@bonigarcia bonigarcia merged commit 413f2c2 into bonigarcia:master Jul 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants