-
-
Notifications
You must be signed in to change notification settings - Fork 680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edge driver url #1323
Edge driver url #1323
Conversation
I believe this PR is no longer required. There was a bug related to msedgedriver (#1320) but it has been fixed in the master branch. Please double check the latest release of WebDriverManager, i.e. version 5.9.2. |
I do not understand why it is no longer required.
#1320 is similar but not same issue. |
That logic (reading from XML to discover edgedriver versions) should not be executed since the driver versions should be found using the online endpoints, e.g., https://msedgedriver.azureedge.net/LATEST_RELEASE_127_WINDOWS So, I have just committed a patch to avoid that logic in the Edge Manager class: f6263e8 Also, you should not change the value of the property https://github.com/bonigarcia/webdrivermanager/actions/runs/10039350820/job/27920720228?pr=1323
Many thanks for your effort but I cannot merge this PR. |
After further investigation, I realized that reading the Edge driver versions from XML can still be helpful in some cases. So please resolve the compilation failures, and I will merge this PR. |
I've fixed the problem. Thanks. |
Purpose of changes
MicrosoftEdge/EdgeWebDriver#146
Types of changes
How has this been tested?
[main] INFO io.github.bonigarcia.wdm.WebDriverManager - Using WebDriverManager to resolve edge
[main] INFO io.github.bonigarcia.wdm.WebDriverManager - Using msedgedriver 125.0.2535.92 (resolved driver for Edge 125)
[main] INFO io.github.bonigarcia.wdm.WebDriverManager - Reading https://msedgewebdriverstorage.blob.core.windows.net/edgewebdriver/?restype=container&comp=list to seek msedgedriver
[main] INFO io.github.bonigarcia.wdm.WebDriverManager - Reading https://msedgewebdriverstorage.blob.core.windows.net/edgewebdriver/?restype=container&comp=list&marker=2%21104%21MDAwMDMzITEyNC4wLjI0NzcuMC9lZGdlZHJpdmVyX3dpbjY0LnppcCEwMDAwMjghOTk5OS0xMi0zMVQyMzo1OTo1OS45OTk5OTk5WiE- to seek msedgedriver
[main] INFO io.github.bonigarcia.wdm.online.Downloader - Downloading https://msedgewebdriverstorage.blob.core.windows.net/edgewebdriver/125.0.2535.92/edgedriver_linux64.zip
[main] INFO io.github.bonigarcia.wdm.online.Downloader - Extracting driver from compressed file edgedriver_linux64.zip
[main] INFO io.github.bonigarcia.wdm.WebDriverManager - Driver location: /home/eartan/Projects/visiumgo/webdrivermanager/msedgedriver