async validate

[ulken]

Took a stab at supporting async validation.

Currently, the UX is suffering, though. The program seemingly hangs, without any feedback to the user. We should probably kick off a spinner or similar.

Potentially by emitting a validate event from core to allow styled prompts to take appropriate action? Or introducing a new state and doing an intermediate render?

Related to #92

[changeset-bot]

🦋 Changeset detected

Latest commit: 19a1903

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@clack/prompts	Minor
@clack/core	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[ulken]

@natemoo-re thoughts?

[natemoo-re]

This looks good! I pushed a change to set a validate state, but it only triggers after 300ms so the UI doesn't flash a temporary loading state if the validation is pretty fast.

Also adds a validate state, which can be triggered during a long async validation.

[natemoo-re]

Feel free to merge if you feel comfortable with this!

[ulken]

Nice solution! I'll make sure to try it out and merge if appeased 😉

[ulken]

The password prompt seems to be broken now (compared to the main branch — even after handling the validate state). When submitting the masked value is seemingly cleared.

[ulken]

It seems like Promise.race() doesn't work as you expect with setTimeout(). It's not cancelled (thus always resolved and rendered). You would need to pass a signal (AbortController) to cancel the timeout.

[ulken]

When the race/timeout is sorted, shouldn't this move closer to the render? No need to set it if never rendered?

[ulken]

Would have to use something like: https://stackoverflow.com/a/39852372

[ulken]

Gah, for unknown reason, the password prompt doesn't like onKeypress to be async.

Simply add an await Promise.resolve() in there and the input is cleared when pressing Enter.

Not sure if readline doesn't like async or something.

[ulken]

Pushed fix for the timeout issue, but have yet to resolve the password prompt not working. I can't understand why it works for text but not password...

[orochaa]

@natemoo-re @ulken @cpreston321 I looked at this, and seems the password prompt was losing the prompt context during async validation, I fixed it on this commit d258379, please check it out!

[negativems]

How is the progress on this?