feat: timer indicator for spinner
#230
Open
+64
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds spinner option for showing timer instead of animated dots at the end
...
.Manually adding timer (or any other custom progress indicator) results in too verbose logging on CI, as each partial update results in new spinner message.
Visualization
CleanShot.2025-01-27.at.16.47.37.mp4
Testing
Run
pnpm spinner-timer
inexamples/basic
. Also checkspinner
andspinner-ci
to ensure that default behavior is not broken.Discussion points
...
loading dots be kept when timer is running? Currently they have a different cadence, which creates a weird effect. If we were to keep them it would make sense to sync them to the timer, i.e. one do per second (or maybe 1/2 second)