Skip to content

Conversation

robertfalkenberg
Copy link

This PR changes unqualified move calls to qualified versions details::move.

This avoids a warning unqualified call to 'std::move' if an unqualified move resolves to std::move.

For more info see -Wunqualified-std-cast-call or https://reviews.llvm.org/D119670?id=408276

Example Warning/Error:

[...]backward.hpp:2642:34: error: unqualified call to 'std::move' [-Werror,-Wunqualified-std-cast-call]
 2642 |                     elf_handle = move(debuglink_elf);
      |                                  ^
      |                                  std::

I think this PR could also replace #349.

This avoids a warning `unqualified call to 'std::move'`
if an unqualified move resolves to std::move.

For more info see -Wunqualified-std-cast-call
@robertfalkenberg
Copy link
Author

Hello @bombela,

if I have overlooked anything that stands in the way of the merge, please let me know. I would be happy to take this into account.

Kind regards

@robertfalkenberg
Copy link
Author

robertfalkenberg commented Sep 1, 2025

Godbolt example with clang 20.1.0: https://godbolt.org/z/Gz8Tqaxqc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant