Allow customization of signal handler in registration, add flushing #259
+22
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for easier wrapping of the already-publicly-exposed handler logic without duplicating the registration logic in the client.
|
Thank you for offering your work. The signal handler that comes with backward-cpp is an example more than something ready for all use-cases. Consider it as a basic example ready for copy paste to make your own. With my experience maintaining this library over the year, I have observed that implementation of signal handlers can change widely depending of the application (sync, async, threading etc). Therefore I think it is better to keep this outside of backward-cpp. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for making this library, it's very useful to us!
This PR tries to address a couple of minor pain points we encountered when using the library:
😄