Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix datetime.datetime.utcnow() #948

Merged
merged 2 commits into from
Feb 1, 2025
Merged

Conversation

thecalamityjoe87
Copy link
Contributor

Update datetime since datetime.utcnow() was deprecated since Python 3.12.

Please make sure to target the "dev" branch if it exists
REMOVE THIS MESSAGE IN THE PULL REQUEST

Update datetime since datetime.utcnow() was deprecated since Python 3.12.
@alexaschor
Copy link

Tagging issue #908. It also looks like the code invokes utcnow in a few other places as well that could be worth updating.

howdy/src/compare.py
74:		_("Date: ") + datetime.datetime.utcnow().strftime("%Y/%m/%d %H:%M:%S UTC"),

howdy/src/snapshot.py
56:	filename = datetime.datetime.utcnow().strftime("%Y%m%dT%H%M%S.jpg")

howdy/src/cli/snap.py
44:	_("Date: ") + datetime.datetime.utcnow().strftime("%Y/%m/%d %H:%M:%S UTC"),

@thecalamityjoe87
Copy link
Contributor Author

Tagging issue #908. It also looks like the code invokes utcnow in a few other places as well that could be worth updating.

howdy/src/compare.py
74:		_("Date: ") + datetime.datetime.utcnow().strftime("%Y/%m/%d %H:%M:%S UTC"),

howdy/src/snapshot.py
56:	filename = datetime.datetime.utcnow().strftime("%Y%m%dT%H%M%S.jpg")

howdy/src/cli/snap.py
44:	_("Date: ") + datetime.datetime.utcnow().strftime("%Y/%m/%d %H:%M:%S UTC"),

Thank you for this. I have updated my pull request.

@boltgolt boltgolt merged commit 7bb7711 into boltgolt:beta Feb 1, 2025
@boltgolt
Copy link
Owner

boltgolt commented Feb 1, 2025

Thank you for these changes! They are much appreciated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants