Skip to content

Commit

Permalink
Merge pull request #853 from Gliese852/fix-wrong-signals
Browse files Browse the repository at this point in the history
Connect to signals of the shown window
  • Loading branch information
boltgolt authored Feb 2, 2025
2 parents a2eabc9 + bcde184 commit 2c5d304
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
8 changes: 4 additions & 4 deletions howdy-gtk/src/onboarding.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,6 @@ def __init__(self):
# Make the class a GTK window
gtk.Window.__init__(self)

self.connect("destroy", self.exit)
self.connect("delete_event", self.exit)

self.builder = gtk.Builder()
self.builder.add_from_file(paths_factory.onboarding_wireframe_path())
self.builder.connect_signals(self)
Expand All @@ -30,6 +27,9 @@ def __init__(self):
self.slidecontainer = self.builder.get_object("slidecontainer")
self.nextbutton = self.builder.get_object("nextbutton")

self.window.connect("destroy", self.exit)
self.window.connect("delete_event", self.exit)

self.slides = [
self.builder.get_object("slide0"),
self.builder.get_object("slide1"),
Expand Down Expand Up @@ -320,7 +320,7 @@ def show_error(self, error, secon=""):
dialog.destroy()
self.exit()

def exit(self, widget=None):
def exit(self, widget=None, context=None):
"""Cleanly exit"""
gtk.main_quit()
sys.exit(0)
8 changes: 4 additions & 4 deletions howdy-gtk/src/window.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,6 @@ def __init__(self):
# Make the class a GTK window
gtk.Window.__init__(self)

self.connect("destroy", self.exit)
self.connect("delete_event", self.exit)

self.builder = gtk.Builder()
self.builder.add_from_file(paths_factory.main_window_wireframe_path())
self.builder.connect_signals(self)
Expand All @@ -35,6 +32,9 @@ def __init__(self):
self.modellistbox = self.builder.get_object("modellistbox")
self.opencvimage = self.builder.get_object("opencvimage")

self.window.connect("destroy", self.exit)
self.window.connect("delete_event", self.exit)

# Init capture for video tab
self.capture = None

Expand Down Expand Up @@ -105,7 +105,7 @@ def on_about_link(self, label, uri):
status, output = subprocess.getstatusoutput(["sudo -u " + user + " timeout 10 xdg-open " + uri])
return True

def exit(self, widget, context):
def exit(self, widget=None, context=None):
"""Cleanly exit"""
if self.capture is not None:
self.capture.release()
Expand Down

0 comments on commit 2c5d304

Please sign in to comment.