Added functions getSensorRawValues()#6
Open
gplante wants to merge 1 commit intobolderflight:mainfrom
Open
Conversation
TheRedstoneHive
approved these changes
Jun 24, 2023
TheRedstoneHive
approved these changes
Jun 30, 2023
TheRedstoneHive
left a comment
TheRedstoneHive
left a comment
There was a problem hiding this comment.
Making the raw accel and gyro arrays public is helpful in the event someone wants to get one of the values, and they can still use the function(s) (both for raw and transformed) to get them all at once. Overall giving the user more options is good.
Author
|
Thanks, this is great. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for you great library.
I needed to access accel/gyro raw values so I added function getSensorRawValues() is Bmi088Accel, Bmi088Gyro and Bmi088 classes.
Thought this might be useful to other developers.