add missing price sets in order #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliver006
reviewed
Dec 6, 2024
andypwarren
force-pushed
the
feature/add-missing-fields
branch
from
8164a97 to
0e2df29
Compare
andypwarren
force-pushed
the
feature/add-missing-fields
branch
from
0e2df29 to
e3c9ca8
Compare
|
released as v4.7.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some price sets were missing in the Order and TaxLine types which meant it wasn't possible to access the presentational amount.
Note it seems TotalDiscountSet was added but it was wrongly mapped to the JSON. It should be
total_discounts_setnottotal_discount_set. I've left it in to avoid a breaking change (although it wont be working correctly if people are using it). Happy to remove it if that's best