Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Greencrab month env #21

Merged
merged 2 commits into from
Nov 27, 2024
Merged

Greencrab month env #21

merged 2 commits into from
Nov 27, 2024

Conversation

jiangjingzhi2003
Copy link
Contributor

First version of greencrab month environment, mainly change the step function.

@felimomo
Copy link
Collaborator

Awesome work Jim! Monthly env looks good! :)

@jiangjingzhi2003 jiangjingzhi2003 merged commit 47a60cb into main Nov 27, 2024
2 checks passed
@cboettig
Copy link
Member

Nice work @jiangjingzhi2003 , this is exciting. I think the natural next step would be to run this through the existing pipeline comparing RL solutions to the best fixed-action-strategy solution like you were doing before. Do you want to take a go at that?

Chances are this will depend on the details of the parameters. Usually with a new environment, the first thing we find is that even for the 'fixed-action' case, the action is often on the boundary of action space (i.e. set no traps ever, set maximum traps), and some adjusting of costs and benefits is required such that the control problem does not reduce to one of these limiting approximations, but it helps build our intuition for the model.

@jiangjingzhi2003
Copy link
Contributor Author

Nice work @jiangjingzhi2003 , this is exciting. I think the natural next step would be to run this through the existing pipeline comparing RL solutions to the best fixed-action-strategy solution like you were doing before. Do you want to take a go at that?

Chances are this will depend on the details of the parameters. Usually with a new environment, the first thing we find is that even for the 'fixed-action' case, the action is often on the boundary of action space (i.e. set no traps ever, set maximum traps), and some adjusting of costs and benefits is required such that the control problem does not reduce to one of these limiting approximations, but it helps build our intuition for the model.

Got it. I will try to get a constant action for the new environment. Also, do we need a "simplified version" for monthly environment like we did for normal greenCrabEnv.

@felimomo
Copy link
Collaborator

felimomo commented Dec 1, 2024 via email

@jiangjingzhi2003
Copy link
Contributor Author

Ah you know I was thinking about that the other day! I think it would even make sense to make those changes in the same monthly environment rather than making a new "simplified" environment. (I dont think my original decision of making a 'normal' and a 'simplified' environment was the best for the project long-term haha.)

On Sun 1. Dec 2024 at 12:40, jim jiang @.> wrote: Nice work @jiangjingzhi2003 https://github.com/jiangjingzhi2003 , this is exciting. I think the natural next step would be to run this through the existing pipeline comparing RL solutions to the best fixed-action-strategy solution like you were doing before. Do you want to take a go at that? Chances are this will depend on the details of the parameters. Usually with a new environment, the first thing we find is that even for the 'fixed-action' case, the action is often on the boundary of action space (i.e. set no traps ever, set maximum traps), and some adjusting of costs and benefits is required such that the control problem does not reduce to one of these limiting approximations, but it helps build our intuition for the model. Got it. I will try to get a constant action for the new environment. Also, do we need a "simplified version" for monthly environment like we did for normal greenCrabEnv. — Reply to this email directly, view it on GitHub <#21 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIFQIMLCUBRVXDYUXZTCZSD2DNJ25AVCNFSM6AAAAABSOVU4H2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMJQGIYDEMZRGQ . You are receiving this because your review was requested.Message ID: @.>

Got it. Yeah, I was thinking about it as well and couldn't come up with a even more simplified version for the monthly environment.

@felimomo
Copy link
Collaborator

felimomo commented Dec 1, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants