Notebook fix #20
Merged
Notebook fix #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@felimomo thanks! It looks like this now fails one of the unit tests? (looks like there are also 2 warnings related to the env, which we might want to consider, but also one assertion test is actually failing) |
cboettig
reviewed
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Erased old notebooks (they were too messy and clunky), created new ones, modified the default param values for greenCrabEnv
@cboettig sorry this took a minute, it's been pretty hectic! But now the notebooks should be looking good and be easily reproducible! Added @jiangjingzhi2003 as a reviewer!