Add tests for reward function for one timesteps

[jiangjingzhi2003]

added test for reward function for one timesteps

1. no trap laid when no crabs
2. all trap laid when no crabs
3. no trap laid when there is large amount of crabs
4. all trap laid when there is large amount of crabs

[cboettig]

Nice work @jiangjingzhi2003 ! @felimomo can you take a quick look over this when you have a chance?

[felimomo]

Awesome progress @jiangjingzhi2003 !! I added a few comments, let me know what you think. (Tomorrow I'll be working offline from the plane—I might not be super responsive, but I'll get back to you on Wednesday!)

[jiangjingzhi2003]

Awesome progress @jiangjingzhi2003 !! I added a few comments, let me know what you think. (Tomorrow I'll be working offline from the plane—I might not be super responsive, but I'll get back to you on Wednesday!)

I don't think I can see your comments. Where did you put it?

[felimomo]

@jiangjingzhi2003 they should appear as threads here! #17 or in the files changed https://github.com/boettiger-lab/rl4greencrab/pull/17/files

[jiangjingzhi2003]

@felimomo It is empty from my end.

[cboettig]

@felimomo i think github waits until you hit 'finish review' to post in-line comments

[felimomo]

Ah thanks Carl, I had completely blanked out on 'hitting send'—sorry about that Jim!

[felimomo]

Hey, was closing it intentional? I think it's not merged to main yet!

[jiangjingzhi2003]

Oh, my bad. My closed it by accident. I will reopen it.

[cboettig]

@felimomo I think GitHub should be giving you the option to "approve" the review after the issues you flagged are resolved. I think we've set it up so only one reviewer needs to review and approve and then you can merge.

Thanks both for your work on this!

I think I'll make students in ESPM-157 learn to review and approve PRs this year -- hope they don't throw me overboard! 🏴‍☠️