-
Notifications
You must be signed in to change notification settings - Fork 47
Add file type option which ignores file extensions other than provided #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mnojek
wants to merge
2
commits into
boakley:master
Choose a base branch
from
mnojek:feature/handle-file-types
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| * Invalid | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| *** Test Cases *** | ||
| Simple Test Case | ||
| Pass Execution Everything's fine |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| *** Test Cases *** | ||
| Simple Test Case | ||
| Pass Execution Everything's fine |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| *** Test Cases *** | ||
| Simple Test Case | ||
| Pass Execution Everything's fine |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,104 @@ | ||
| *** Settings *** | ||
| Documentation Check if rflint reads supported file formats | ||
| Library OperatingSystem | ||
| Library Process | ||
| Library String | ||
| Resource SharedKeywords.robot | ||
|
|
||
|
|
||
| *** Test Cases *** | ||
| All Supported File Types | ||
| [Template] Run Rflint And Verify There Are No Errors For Supported File Types | ||
| robot resource tsv | ||
|
|
||
| .robot And .resource Supported File Types | ||
| [Template] Run Rflint And Verify There Are No Errors For Supported File Types | ||
| robot resource | ||
|
|
||
| .resource And .tsv Supported File Types | ||
| [Template] Run Rflint And Verify There Are No Errors For Supported File Types | ||
| resource tsv | ||
|
|
||
| .robot And .tsv Supported File Types | ||
| [Template] Run Rflint And Verify There Are No Errors For Supported File Types | ||
| robot tsv | ||
|
|
||
| Only .robot Supported File Type | ||
| [Template] Run Rflint And Verify There Are No Errors For Supported File Types | ||
| robot | ||
|
|
||
| Only .resource Supported File Type | ||
| [Template] Run Rflint And Verify There Are No Errors For Supported File Types | ||
| resource | ||
|
|
||
| Only .tsv Supported File Type | ||
| [Template] Run Rflint And Verify There Are No Errors For Supported File Types | ||
| tsv | ||
|
|
||
| Only .pdf Unsupported File Type | ||
| [Template] Run Rflint And Verify That Unsupported File Types Returned Errors | ||
|
|
||
| Specific .txt File With .robot Provided File Type | ||
| [Template] Run Rflint And Verify There Are No Output For Not Matching File Types | ||
| test_data/acceptance/filetypes/test.txt robot | ||
|
|
||
| Specific .robot File With .resource Provided File Type | ||
| [Template] Run Rflint And Verify There Are No Output For Not Matching File Types | ||
| test_data/acceptance/filetypes/test.robot resource | ||
|
|
||
| Specific .resource File With .robot And .tsv Provided File Type | ||
| [Template] Run Rflint And Verify There Are No Output For Not Matching File Types | ||
| test_data/acceptance/filetypes/test.resource robot tsv | ||
|
|
||
| Specific .tsv File With .robot And .resource Provided File Type | ||
| [Template] Run Rflint And Verify There Are No Output For Not Matching File Types | ||
| test_data/acceptance/filetypes/test.tsv robot resource | ||
|
|
||
|
|
||
| *** Keywords *** | ||
| Run Rflint And Verify There Are No Errors For Supported File Types | ||
| [Arguments] @{extensions} | ||
| ${file_types} Parse File Types @{extensions} | ||
| Run rf-lint with the following options: | ||
| ... --filetypes ${file_types} | ||
| ... test_data/acceptance/filetypes | ||
| FOR ${file_type} IN @{extensions} | ||
| Should Contain ${result.stdout} test.${file_type} | ||
| END | ||
| Should Be Empty ${result.stderr} | ||
|
|
||
| Run Rflint And Verify That Unsupported File Types Returned Errors | ||
| [Arguments] @{extensions} | ||
| ${file_types} Parse File Types @{extensions} | ||
| Run rf-lint with the following options: | ||
| ... --filetypes ${file_types} | ||
| ... test_data/acceptance/filetypes | ||
| FOR ${file_type} IN @{extensions} | ||
| Should Contain ${result.stderr} rflint: File extension .${file_type} is not supported | ||
| END | ||
| Should Be Empty ${result.stdout} | ||
|
|
||
| Run Rflint And Verify There Are No Output For Not Matching File Types | ||
| [Arguments] ${path_to_file} @{extensions} | ||
| ${file_types} Parse File Types @{extensions} | ||
| Run rf-lint with the following options: | ||
| ... -t ${file_types} | ||
| ... ${path_to_file} | ||
| FOR ${file_type} IN @{extensions} | ||
| Should Be Empty ${result.stdout} ${EMPTY} | ||
| Should Be Empty ${result.stderr} ${EMPTY} | ||
| END | ||
| Should Be Empty ${result.stderr} | ||
|
|
||
| Parse File Types | ||
| [Arguments] @{filetypes} | ||
| ${types} Set Variable ${EMPTY} | ||
| FOR ${index} ${file_type} IN ENUMERATE @{filetypes} | ||
| ${types} Run Keyword If ${index}==${0} | ||
| ... Set Variable ${file_type} | ||
| ... ELSE | ||
| ... Set Variable ${types},${file_type} | ||
| END | ||
| Log Provided filetypes: ${types} | ||
| [Return] ${types} | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Misaligned
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did it on purpose, please look at the whole file. But I can revert it if it looks strange. What do you think?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I see, thanks to this format it's easy to see that you're testing this or that file format combination. But maybe you could use this approach?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, another approach is to use arguments embedded in keyword name. I will think which one is the best for this use.