Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extract small_map as separate utility crate #4214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
extract small_map as separate utility crate #4214
Changes from all commits
16ee23c
6ab4ae3
ec7a64c
b99e6a3
91dd81c
e27e71b
d8e9069
0c190db
bba0272
ac0ea5d
bc5d29c
f967c48
e3ad8a2
c3db0df
bb0cccb
89b998c
10a2f7a
75cd030
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both
small_map
andsmallmap
are taken names. Maybe we should think of a different name? any ideas @boa-dev/maintainers ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small_btree
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe describe the data-structure instead, something like
SmallMap is an inline vec that grows into a heap map past ARRAY_SIZE
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh, actually after seeing the broken lints, I'm wondering if both
insert
andremove
should have amust_use
attribute. It might be a bit too strictWhile the failure's aren't exactly incorrect, it feels like a negative of the API to force users to use
let _ = map.insert(value)
vs.map.insert(value)