Skip to content

feat: merge master back to develop #657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
annielz merged 6 commits into from
Apr 21, 2025
Merged

feat: merge master back to develop #657

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ae16fa0
Merge pull request #649 from bnb-chain/develop
annielz Nov 21, 2024
55bf692
feat: allow change GvgStakingPerBytes for gvg updateParams
annielz Apr 16, 2025
f07bfba
fix: lint
annielz Apr 16, 2025
974306f
Merge pull request #655 from bnb-chain/feat-update-gvg-param-rule
annielz Apr 17, 2025
6859cc2
release: prepare for v1.10.1
annielz Apr 17, 2025
5a0f69f
Merge pull request #656 from bnb-chain/release-v1.10.1
annielz Apr 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,6 @@ jobs:
uses: golangci/golangci-lint-action@v3
with:
# Optional: version of golangci-lint to use in form of v1.2 or v1.2.3 or `latest` to use the latest version
version: latest
version: v1.54
skip-pkg-cache: true
args: --timeout=99m
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Changelog

## V1.10.1
This release contains 1 new feature

Features:
* [#655] https://github.com/bnb-chain/greenfield/pull/655 feat: allow change GvgStakingPerBytes for gvg updateParams

## V1.10.0
This release introduces the Savanna upgrade.

Expand Down
4 changes: 2 additions & 2 deletions x/virtualgroup/keeper/msg_server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@ func (k msgServer) UpdateParams(goCtx context.Context, req *types.MsgUpdateParam

// Some parameters cannot be modified
originParams := k.GetParams(ctx)
if !req.Params.GvgStakingPerBytes.Equal(originParams.GvgStakingPerBytes) || req.Params.DepositDenom != originParams.DepositDenom {
return nil, errors.ErrInvalidParameter.Wrapf("GvgStakingPerBytes and depositDenom are not allow to update, current: %v, %v, got: %v, %v", originParams.GvgStakingPerBytes, originParams.DepositDenom, req.Params.GvgStakingPerBytes, req.Params.DepositDenom)
if req.Params.DepositDenom != originParams.DepositDenom {
return nil, errors.ErrInvalidParameter.Wrapf("DepositDenom is not allow to update, current: %v, got: %v", originParams.DepositDenom, req.Params.DepositDenom)
}

if err := k.SetParams(ctx, req.Params); err != nil {
Expand Down
Loading