changes the default for checking the SDK version and treating it as a breaking change to off
#184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… breaking change to `off` Changing the SDK version can't break existing consumer code as pub would not consider the new package that has a non-fitting SDK version boundary. That way the existing code would continue to use the older version that still has a fitting SDK version. A package owner might still consider introducing a major version bump in that case, that's why this option is still there but off by default
devmil
requested review from
adamgic,
fwagner,
fabiomcarneiro and
klink182
as code owners
jonas2808
approved these changes
Sep 30, 2024
adamgic
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changing the SDK version can't break existing consumer code as pub would not consider the new package that has a non-fitting SDK version boundary.
That way the existing code would continue to use the older version that still has a fitting SDK version.
A package owner might still consider introducing a major version bump in that case, that's why this option is still there but off by default
Type of Change
Fixes #183